From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/4] imx: iomux-v3: Include PKE and PUE to pad control pull definitions
Date: Sun, 28 Apr 2013 11:21:37 +0200 [thread overview]
Message-ID: <517CEA21.5040303@denx.de> (raw)
In-Reply-To: <1366976088-30499-4-git-send-email-benoit.thebaudeau@advansee.com>
On 26/04/2013 13:34, Beno?t Th?baudeau wrote:
> PUE requires PKE to mean something, as do pull values with PUE, so do not
> compell users to explicitly use PKE and PUE everywhere. This is also what is
> done on Linux and what has already been done for i.MX51.
>
> By the way, remove some unused pad control definitions.
>
> There is no change of behavior.
>
> Note that SPI_PAD_CTRL was defined by several boards with a pull value, but
> without PKE or PUE, which means that no pull was actually enabled in the pad.
> This might be a bug in those boards, but this patch does not change the
> behavior, so it just removes the meaningless pull value from those definitions.
>
> Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
> ---
Applied to u-boot-imx, thanks.
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2013-04-28 9:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-26 11:34 [U-Boot] [PATCH 1/4] imx: iomux-v3: Fix common pad control definitions Benoît Thébaudeau
2013-04-26 11:34 ` [U-Boot] [PATCH 2/4] imx: iomux-v3: cosmetic: Reorganize definitions Benoît Thébaudeau
2013-04-28 9:21 ` Stefano Babic
2013-04-26 11:34 ` [U-Boot] [PATCH 3/4] imx: iomux-v3: Restore Linux's NEW_PAD_CTRL() macro Benoît Thébaudeau
2013-04-28 9:21 ` Stefano Babic
2013-04-26 11:34 ` [U-Boot] [PATCH 4/4] imx: iomux-v3: Include PKE and PUE to pad control pull definitions Benoît Thébaudeau
2013-04-28 9:21 ` Stefano Babic [this message]
2013-04-28 9:20 ` [U-Boot] [PATCH 1/4] imx: iomux-v3: Fix common pad control definitions Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517CEA21.5040303@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.