From: Clemens Ladisch <clemens@ladisch.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org,
linux1394-devel@lists.sourceforge.net, perex@perex.cz
Subject: Re: [alsa-devel] [PATCH 1/4] Rename functions, structure and member name for AMDTP
Date: Sun, 28 Apr 2013 14:52:38 +0200 [thread overview]
Message-ID: <517D1B96.3070304@ladisch.de> (raw)
In-Reply-To: <1367125334-446-2-git-send-email-o-takashi@sakamocchi.jp>
Takashi Sakamoto wrote:
> This patch rename some functions, structure and member name to reuse them
> in both AMDTP receive and AMDTP transmit stream.
> +++ b/sound/firewire/amdtp.c
> -int amdtp_out_stream_init(struct amdtp_out_stream *s, struct fw_unit *unit,
> - enum cip_out_flags flags)
> +int amdtp_stream_init(struct amdtp_stream *s, struct fw_unit *unit,
> + enum cip_flags flags)
Please adjust the indentation in such cases.
Regards,
Clemens
------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
next prev parent reply other threads:[~2013-04-28 12:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-28 5:02 [PATCH 0/4] snd-firewire-lib: add handling AMDTP receive stream Takashi Sakamoto
2013-04-28 5:02 ` [PATCH 1/4] Rename functions, structure and member name for AMDTP Takashi Sakamoto
2013-04-28 12:52 ` Clemens Ladisch [this message]
2013-04-29 4:21 ` Takashi Sakamoto
2013-04-28 5:02 ` [PATCH 2/4] Add macros for fixed value related to AMDTP Takashi Sakamoto
2013-04-28 5:02 ` [PATCH 3/4] Add "direction" member to amdtp_stream structure for AMDTP Takashi Sakamoto
2013-04-28 5:02 ` [PATCH 4/4] Add handling AMDTP receive stream Takashi Sakamoto
2013-04-28 12:52 ` [alsa-devel] " Clemens Ladisch
2013-04-29 4:30 ` Takashi Sakamoto
2013-04-29 9:47 ` [PATCH v2 0/4] snd-firewire-lib: add " Takashi Sakamoto
2013-04-29 9:47 ` [PATCH 1/4] Rename functions, structure and member name for AMDTP Takashi Sakamoto
2013-04-29 9:47 ` [PATCH 2/4] Add macros for fixed value related to AMDTP Takashi Sakamoto
2013-04-29 9:47 ` [PATCH 3/4] Add "direction" member to amdtp_stream structure for AMDTP Takashi Sakamoto
2013-04-29 9:47 ` [PATCH 4/4] Add handling AMDTP receive stream Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517D1B96.3070304@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=o-takashi@sakamocchi.jp \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.