From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marek Marczykowski Subject: Re: [PATCH 4/7] minios: add gnttab_find_grant_of_page Date: Mon, 29 Apr 2013 00:51:28 +0200 Message-ID: <517DA7F0.6020203@invisiblethingslab.com> References: <20130428224138.GJ4962@type.youpi.perso.aquilenet.fr> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============6790819850669395756==" Return-path: In-Reply-To: <20130428224138.GJ4962@type.youpi.perso.aquilenet.fr> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Samuel Thibault , xen-devel@lists.xen.org, Stefano Stabellini , Ian Jackson , Ian Campbell List-Id: xen-devel@lists.xenproject.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --===============6790819850669395756== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="----enig2UKIICKFGXEXGCHSEBWEJ" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2UKIICKFGXEXGCHSEBWEJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 29.04.2013 00:41, Samuel Thibault wrote: > Marek Marczykowski, le Tue 23 Apr 2013 05:16:21 +0200, a =C3=A9crit : >> Needed to implement minios_gntshr_munmap without introducing additiona= l >> mapping (frame->gref). >=20 > I agree on the principle, given the comment you have put. >=20 >> +/* This function is used by gnttab_munmap call. It is rather rare to = call it - >> + * mostly at sthudown, so save memory at price of efficiency */ >=20 > Better not introduce the typo, however ;) Oops ;) >> +grant_ref_t >> +gnttab_find_grant_of_page(void *map) >> +{ >> + unsigned long flags; >> + int i, mfn; >> + grant_ref_t ref =3D 0; >> + >> + mfn =3D virt_to_mfn(map); >> + local_irq_save(flags); >=20 > Why disabling IRQs? I've just copied it from get_free_entry. But indeed, as I don't modify th= e table here, probably it can be dropped. --=20 Best Regards / Pozdrawiam, Marek Marczykowski Invisible Things Lab ------enig2UKIICKFGXEXGCHSEBWEJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJRfafwAAoJENuP0xzK19csFs0H/1btJxgYksqzXNzPI7vvfUA3 awKvh5qhcpzmV2VuZQA5IAvRB2cGHuy+SOfbzzLjmt//EWJk7DgFJLmbmrWZl9CZ C13HQ8gXC/ZRpFWUfdJXrU3v8qhPH62VhCZp5EU8WWfkvhbWiv5rnazF5FTplHdl 0l+w/uLeKWaonb1VFhpFKsj1LsH+AQ0fyoA1UWpdDcmnASj+KehVtxvYI7zRitI7 gaooJFMzY0e4FrT0WyFDaIDX7GM3yJqwxH3Jla3ravKrGVjupN7ubBTuwdB7Icbu 6jl6lPx3DDsodeREVaABHiob7s71jghGwbjwicbJxDKBBNsfQZDheOKnl+KKHBY= =c6I/ -----END PGP SIGNATURE----- ------enig2UKIICKFGXEXGCHSEBWEJ-- --===============6790819850669395756== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============6790819850669395756==--