[ath9k-devel] [PATCH 20/20] ath10k: Remove unneeded locks during HTT RX attach

[Michal Kazior <michal.kazior@tieto.com>]

On 29/04/13 10:14, Sujith Manoharan wrote:
> Michal Kazior wrote:
>> I'm not even sure if we should abort right away. We replenish htt rx
>> buffers using GFP_ATOMIC allocation. This can fail under memory pressure
>> more often (then, say, GFP_KERNEL). I wouldn't really consider this as
>> fatal error. Although we could probably have a ath10k_warn/info if the
>> initial allocation doesn't fill everything up. Perhaps we could fail
>> only if the fill_cnt is still 0, or below a defined threshold?
>>
>> We could also try and split the replenishing functions and use
>> GFP_KERNEL allocation during htt rx attach.
>
> We do a bunch of allocations using GFP_ATOMIC after htt_attach().
> Proceeding with initialization at this point seems wrong and programming
> the FW with RX ring configuration via HTT_H2T_MSG_TYPE_RX_RING_CFG even though
> host setup failed is probably incorrect ?

You're right.


> An updated patch:
>
> [PATCH] ath10k: Remove unneeded locks during HTT RX attach
>
> Fix two issues:
>
> * Bail out properly when RX buffer allocation fails at init time.
> * Do not acquire the rx ring lock during attach() since we
>    don't rearm the replenish timer.
>
> Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
> ---

Looks good to me now.


-- Pozdrawiam / Best regards, Michal Kazior.