From: Paolo Bonzini <pbonzini@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>,
qemu-devel@nongnu.org, Ian Main <imain@redhat.com>,
dietmar@proxmox.com
Subject: Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command
Date: Mon, 29 Apr 2013 11:27:01 +0200 [thread overview]
Message-ID: <517E3CE5.5030202@redhat.com> (raw)
In-Reply-To: <20130429072110.GA13488@stefanha-thinkpad.redhat.com>
Il 29/04/2013 09:21, Stefan Hajnoczi ha scritto:
> > I'd really love to see us change 'BlockJobInfo' to use an enum for
> > 'type', instead of its open-coded 'str'. Likewise, the block-job
> > related events in QMP/qmp-events.txt should be updated to refer to the
> > enum instead of also being open-coded 'str'.
>
> Since the block job QMP API has been in released I'm not sure changing
> this is worthwhile. QEMU and libvirt would have to maintain
> compatibility so the code will just be duplicated.
I don't think this would change the actual data on the wire. However,
it would let libvirt know the supported block job types by introspecting
the enum.
Paolo
next prev parent reply other threads:[~2013-04-29 9:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-23 16:25 [Qemu-devel] [PATCH 0/3] block: block-backup live backup command Stefan Hajnoczi
2013-04-23 16:25 ` [Qemu-devel] [PATCH 1/3] block: add basic backup support to block driver Stefan Hajnoczi
2013-04-23 16:25 ` [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command Stefan Hajnoczi
2013-04-26 22:52 ` Eric Blake
2013-04-26 22:53 ` Eric Blake
2013-04-26 22:58 ` Eric Blake
2013-04-29 7:21 ` Stefan Hajnoczi
2013-04-29 9:27 ` Paolo Bonzini [this message]
2013-04-29 15:51 ` Eric Blake
2013-05-01 11:55 ` Stefan Hajnoczi
2013-04-23 16:25 ` [Qemu-devel] [PATCH 3/3] qemu-iotests: add 054 block-backup test case Stefan Hajnoczi
2013-04-23 16:49 ` [Qemu-devel] [PATCH 0/3] block: block-backup live backup command Eric Blake
2013-04-23 16:57 ` Paolo Bonzini
2013-04-24 7:41 ` Stefan Hajnoczi
2013-04-24 12:44 ` Eric Blake
2013-04-27 5:37 ` Wenchao Xia
2013-04-29 7:22 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517E3CE5.5030202@redhat.com \
--to=pbonzini@redhat.com \
--cc=dietmar@proxmox.com \
--cc=famz@redhat.com \
--cc=imain@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.