Re: flexcan driver: tx_bytes counter never incremented when CAN_RAW_LOOPBACK removed?

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 982 bytes --]

On 04/29/2013 12:40 PM, Stephane Grosjean wrote:
> Hi Marc,
> 
> Playing with the flexcan driver, I've seen that the tx_bytes counter
> always equals 0 while tx_packets increases.
> I simply removed the CAN_RAW_LOOPBACK option from my CAN socket, so I
> suppose that:
> 
> stats->tx_bytes += can_get_echo_skb(dev, 0);
> 
> doesn't do what it should.
> Am I wrong?

Let me see. Yes you're right. can_put_echo_skb() only queues the CAN
frame if CAN_RAW_LOOPBACK is set.

We either can change that can_put_echo_skb() always queues the CAN frame
or that can_get_echo_skb() returns the correct number of bytes even if
the CAN frame is not queued or put the mechanism in each driver.

Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 263 bytes --]