From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48432) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWmI4-00016E-7b for qemu-devel@nongnu.org; Mon, 29 Apr 2013 07:30:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWmHz-0000Hj-Dy for qemu-devel@nongnu.org; Mon, 29 Apr 2013 07:30:40 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38900 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWmHz-0000HV-8Z for qemu-devel@nongnu.org; Mon, 29 Apr 2013 07:30:35 -0400 Message-ID: <517E59D2.1080405@suse.de> Date: Mon, 29 Apr 2013 13:30:26 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1367148131-1440-1-git-send-email-afaerber@suse.de> <20130429122948.41f3e03e@thinkpad> In-Reply-To: <20130429122948.41f3e03e@thinkpad> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH RFC qom-cpu-next] apic: QOM'ify APICCommonState casts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Igor Mammedov Cc: anthony@codemonkey.ws, jan.kiszka@web.de, qemu-devel@nongnu.org, gleb@redhat.com, ehabkost@redhat.com Am 29.04.2013 12:29, schrieb Igor Mammedov: > On Sun, 28 Apr 2013 13:22:10 +0200 > Andreas F=E4rber wrote: >=20 >> Necessary to change the name of ICCDevice's parent object field. >> >> Signed-off-by: Andreas F=E4rber >> --- >> Could any of the APIC experts please review whether I'm touching any = hot path? >> Not sure if this was a mix of pre- and post-QOM code or intentional..= . Thanks. >> >> hw/i386/kvm/apic.c | 4 ++-- >> hw/intc/apic.c | 20 +++++++++++--------- >> hw/intc/apic_common.c | 10 +++++----- >> include/hw/cpu/icc_bus.h | 2 +- >> 4 files changed, 19 insertions(+), 17 deletions(-) >> > [...] >> =20 >> diff --git a/include/hw/cpu/icc_bus.h b/include/hw/cpu/icc_bus.h >> index b550070..f2c8a50 100644 >> --- a/include/hw/cpu/icc_bus.h >> +++ b/include/hw/cpu/icc_bus.h >> @@ -51,7 +51,7 @@ typedef struct ICCBus { >> */ >> typedef struct ICCDevice { >> /*< private >*/ >> - DeviceState qdev; >> + DeviceState parent_obj; > This hunk doesn't apply to qpm-cpu-next. > It looks like it's accidentally crept in=20 > https://github.com/afaerber/qemu-cpu/commit/a7ae7cd073cc2b20de3372edc84= ec5a01e88e55d Yeah, sorry, forgot to push latest qom-cpu-next (but today that includes preliminary APIC QOM'ification not yet ready for qom-cpu). Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg