Re: [PATCH] fix make headers_install when path is too long

[Nicolas Dichtel <nicolas.dichtel@6wind.com>]

Le 29/04/2013 14:13, Michal Marek a écrit :
> On 26.4.2013 20:57, Sam Ravnborg wrote:
>> On Fri, Apr 26, 2013 at 06:36:38PM +0200, Nicolas Dichtel wrote:
>>> If headers_install is executed from a deep/long directory structure, the
>>> shell's maximum argument length can be execeeded, which breaks the operation
>>> with:
>>>
>>> | make[2]: execvp: /bin/sh: Argument list too long
>>> | make[2]: ***
>>>
>>> Instead of passing each files name with the entire path, I give only the file
>>> name without the source path and give this path as a new argument to
>>> headers_install.pl.
>>>
>>> Because there is three possible path, I have tree input-files list, one per
>>> path.
>>>
>>> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
>>> ---
>>>
>>> I come back to this issue. Here is another proposal to fix this pb.
>>> Comments are welcome.
>>>
>>>   scripts/Makefile.headersinst | 20 ++++++++++++++------
>>>   scripts/headers_install.pl   |  8 ++++----
>>
>> In the kbuild tree the perl script has been replaced by a shell script.
>> You should base you patch on the kbuild-tree (or -next).
>
> Yes. Otherwise, the patch looks good. At least until the number of
> userspace headers explodes :-).
It should be ok for the next 2 or 3 versions ;-)