From: Nicolas Schichan <nschichan@freebox.fr>
To: Xi Wang <xi.wang@gmail.com>
Cc: Daniel Borkmann <dborkman@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Heiko Carstens <heiko.carstens@de.ibm.com>,
Will Drewry <wad@chromium.org>,
Eric Dumazet <edumazet@google.com>,
Russell King <linux@arm.linux.org.uk>,
David Laight <david.laight@aculab.com>,
"David S. Miller" <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v2 net-next 3/3] ARM: net: bpf_jit_32: support BPF_S_ANC_SECCOMP_LD_W instruction
Date: Mon, 29 Apr 2013 14:39:29 +0200 [thread overview]
Message-ID: <517E6A01.4040407@freebox.fr> (raw)
In-Reply-To: <CAKU6vyathpp4Ky_kcTu_WFenLEdo9Mai4TUE=EWYo9=UuQUMcg@mail.gmail.com>
On 04/27/2013 08:32 PM, Xi Wang wrote:
> On Sat, Apr 27, 2013 at 2:27 AM, Daniel Borkmann <dborkman@redhat.com> wrote:
>> Arent't you doing here a similar thing in terms of getting arch as Eric
>> criticized (Nicolas' implementation does not use that part btw.)? Also,
>> even if it would be possible here, now your 2 JIT implementations differ
>> in behaviour. I think this is unintended.
>
> Eric's comment was about x86, where the audit arch could change on the
> fly. For ARM, the audit arch doesn't change---syscall_get_arch()
> always returns AUDIT_ARCH_ARM.
Hi,
Indeed, syscall_get_arch() will only return AUDIT_ARCH_ARM on ARM right now.
This might be more future proof to call syscall_get_arch() though. The main
reason that comes to my mind would be an AArch64 kernel with support for
AArch32 userland tasks. This would I expect require a different AUDIT_ARCH
constant to differenciate between AArch64 and AArch32 tasks.
Regards,
--
Nicolas Schichan
Freebox SAS
prev parent reply other threads:[~2013-04-29 12:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-27 2:17 [PATCH v2 net-next 0/3] seccomp filter JIT Xi Wang
2013-04-27 2:17 ` [PATCH v2 net-next 1/3] filter: refactor BPF JIT for seccomp filters Xi Wang
2013-04-27 2:17 ` [PATCH v2 net-next 2/3] x86: bpf_jit_comp: support BPF_S_ANC_SECCOMP_LD_W instruction Xi Wang
2013-04-28 1:21 ` Eric Dumazet
2013-04-29 7:48 ` Xi Wang
2013-04-27 2:17 ` [PATCH v2 net-next 3/3] ARM: net: bpf_jit_32: " Xi Wang
2013-04-27 6:27 ` Daniel Borkmann
2013-04-27 18:32 ` Xi Wang
2013-04-29 10:16 ` Daniel Borkmann
2013-04-29 12:39 ` Nicolas Schichan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517E6A01.4040407@freebox.fr \
--to=nschichan@freebox.fr \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=david.laight@aculab.com \
--cc=dborkman@redhat.com \
--cc=edumazet@google.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=wad@chromium.org \
--cc=xi.wang@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.