From: Paolo Bonzini <pbonzini@redhat.com>
To: Dunrong Huang <riegamaths@gmail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] Makefile: Fix build breakage
Date: Mon, 29 Apr 2013 16:22:42 +0200 [thread overview]
Message-ID: <517E8232.5020202@redhat.com> (raw)
In-Reply-To: <CAOZVR5ZyrU3asoL_QPzYKOqGxb6FiENu=XGhTFtcgW-pC44gpA@mail.gmail.com>
Il 29/04/2013 15:33, Dunrong Huang ha scritto:
>
> Yes, this way works for me.
>
> diff --git a/rules.mak b/rules.mak
> index 292a422..2572070 100644
> --- a/rules.mak
> +++ b/rules.mak
> @@ -15,7 +15,7 @@ MAKEFLAGS += -rR
> QEMU_DGFLAGS += -MMD -MP -MT $@ -MF $(*D)/$(*F).d
>
> # Same as -I$(SRC_PATH) -I., but for the nested source/object directories
> -QEMU_CFLAGS += -I$(<D) -I$(@D)
> +QEMU_INCLUDES += -I$(<D) -I$(@D)
>
> but I don't know if it will break other build, e.g. mingw build.
Please submit it, it is a better fix. Make sure you put "1.5" in the
subject.
Paolo
next prev parent reply other threads:[~2013-04-29 14:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-28 18:04 [Qemu-devel] [PATCH] Makefile: Fix build breakage Dunrong Huang
2013-04-29 8:19 ` Paolo Bonzini
2013-04-29 13:33 ` Dunrong Huang
2013-04-29 14:22 ` Paolo Bonzini [this message]
2013-04-29 23:58 ` Peter Crosthwaite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517E8232.5020202@redhat.com \
--to=pbonzini@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=qemu-devel@nongnu.org \
--cc=riegamaths@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.