From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42598)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UWp6s-0007T6-0P
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 10:31:20 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UWp6q-0003fa-Mk
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 10:31:17 -0400
Received: from cantor2.suse.de ([195.135.220.15]:48775 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1UWp6q-0003fJ-Ga
	for qemu-devel@nongnu.org; Mon, 29 Apr 2013 10:31:16 -0400
Message-ID: <517E8432.6050105@suse.de>
Date: Mon, 29 Apr 2013 16:31:14 +0200
From: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <517E68FC.6030400@siemens.com>
In-Reply-To: <517E68FC.6030400@siemens.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] qdev: Report errors collected during
 device realization
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel <qemu-devel@nongnu.org>, Markus Armbruster <armbru@redhat.com>, Luiz Capitulino <lcapitulino@redhat.com>

Am 29.04.2013 14:35, schrieb Jan Kiszka:
> Better than just releasing the error object silently.
>=20
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>

Reviewed-by: Andreas F=E4rber <afaerber@suse.de>

but CC'ing monitor guys to verify this is the right print function.

Andreas

> ---
>  hw/core/qdev.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>=20
> diff --git a/hw/core/qdev.c b/hw/core/qdev.c
> index 4eb0134..ab1d8f5 100644
> --- a/hw/core/qdev.c
> +++ b/hw/core/qdev.c
> @@ -162,6 +162,7 @@ int qdev_init(DeviceState *dev)
> =20
>      object_property_set_bool(OBJECT(dev), true, "realized", &local_err=
);
>      if (local_err !=3D NULL) {
> +        qerror_report_err(local_err);
>          error_free(local_err);
>          qdev_free(dev);
>          return -1;
>=20


--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg