From: Paolo Bonzini <pbonzini@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Gleb Natapov <gleb@redhat.com>,
Marcelo Tosatti <mtosatti@redhat.com>,
"Ren, Yongjie" <yongjie.ren@intel.com>, kvm <kvm@vger.kernel.org>,
"Nakajima, Jun" <jun.nakajima@intel.com>
Subject: Re: [PATCH] KVM: x86: Account for failing enable_irq_window for NMI window request
Date: Mon, 29 Apr 2013 16:37:48 +0200 [thread overview]
Message-ID: <517E85BC.6000809@redhat.com> (raw)
In-Reply-To: <517D5104.20207@web.de>
Il 28/04/2013 18:40, Jan Kiszka ha scritto:
> diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c
> index 8747fef..6974ca8 100644
> --- a/arch/x86/kvm/x86.c
> +++ b/arch/x86/kvm/x86.c
> @@ -5754,7 +5754,8 @@ static int vcpu_enter_guest(struct kvm_vcpu *vcpu)
>
> /* enable NMI/IRQ window open exits if needed */
> if (vcpu->arch.nmi_pending)
> - kvm_x86_ops->enable_nmi_window(vcpu);
> + req_immediate_exit =
> + kvm_x86_ops->enable_nmi_window(vcpu);
!= 0 for consistency with below?
Paolo
> else if (kvm_cpu_has_injectable_intr(vcpu) || req_int_win)
> req_immediate_exit =
> kvm_x86_ops->enable_irq_window(vcpu) != 0;
> -- 1.7.3.4
next prev parent reply other threads:[~2013-04-29 14:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-28 7:24 [PATCH] KVM: nVMX: Skip PF interception check when queuing during nested run Jan Kiszka
2013-04-28 10:36 ` Gleb Natapov
2013-04-28 14:30 ` Ren, Yongjie
2013-04-28 14:33 ` Gleb Natapov
2013-04-28 16:20 ` Ren, Yongjie
2013-04-28 16:26 ` Jan Kiszka
2013-04-28 16:40 ` [PATCH] KVM: x86: Account for failing enable_irq_window for NMI window request Jan Kiszka
2013-04-29 14:37 ` Paolo Bonzini [this message]
2013-04-29 14:46 ` [PATCH v2] " Jan Kiszka
2013-04-29 15:38 ` Paolo Bonzini
2013-05-03 1:17 ` Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517E85BC.6000809@redhat.com \
--to=pbonzini@redhat.com \
--cc=gleb@redhat.com \
--cc=jan.kiszka@web.de \
--cc=jun.nakajima@intel.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=yongjie.ren@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.