From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC 04/29] xen/arm: Bump early printk internal buffer to 512 Date: Mon, 29 Apr 2013 16:22:27 +0100 Message-ID: <517E9033.5070008@linaro.org> References: <68b654b765f335f62e7ec177602583d57e1d7a34.1367188423.git.julien.grall@linaro.org> <1367247680.3142.327.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1367247680.3142.327.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Anthony Perard , "patches@linaro.org" , Stefano Stabellini , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 04/29/2013 04:01 PM, Ian Campbell wrote: > On Mon, 2013-04-29 at 00:01 +0100, Julien Grall wrote: >> When debug is enabled in device tree code, some lines >> are bigger than 80 characters. > > I'm a little concerned about putting such a relatively large thing on > the stack. Especially the initstack which I have a feeling is only 4K. > > We are single processor when early_printk is used, right? So a static > __initdata buffer would also work? Right. I will fix it in the next patch series. -- Julien