From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH 2 of 2] x86/VT-d: Sandy-Bridge BT98 Erratum
Date: Mon, 29 Apr 2013 16:23:36 +0100
Message-ID: <517E9078.2000805@citrix.com>
References: <89ba0b0192c4809a02d9.1366999904@andrewcoop.uk.xensource.com>
	<9c2aed177e25f5cce079.1366999905@andrewcoop.uk.xensource.com>
	<517EAA2C02000078000D1BF7@nat28.tlf.novell.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <517EAA2C02000078000D1BF7@nat28.tlf.novell.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Jan Beulich <JBeulich@suse.com>
Cc: "Keir (Xen.org)" <keir@xen.org>, Xiantao Zhang <xiantao.zhang@intel.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 29/04/13 16:13, Jan Beulich wrote:
>>>> On 26.04.13 at 20:11, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
>> @@ -288,9 +309,12 @@ void __init platform_quirks_init(void)
>>      /* ioremap IGD MMIO+0x2000 page */
>>      map_igd_reg();
>>  
>> -    /* Tylersburg interrupt remap quirk */
>> +    /* Interrupt remapping quirks */
>>      if ( iommu_intremap )
>> +    {
>>          tylersburg_intremap_quirk();
>> +        snb_bt98_erratum();
>> +    }
> Considering the nature of the erratum, keying this off
> iommu_intremap seems wrong - iommu_qinval ought to be used
> instead - intel_vtd_setup() takes care to disable interrupt
> remapping when queued invalidation is not available, yet when
> you make the above conditional upon iommu_intremap, queued
> invalidation could still get enabled (and used for whatever else
> purposes, now or in the future).
>
> Jan
>

Yes - I mentally had the erratum the wrong way around, as intremap is
the visible impact of it.

I shall respin once hearing back from Xiantao, especially regarding the
first patch.

~Andrew