From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36983) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWqMq-0003cr-B5 for qemu-devel@nongnu.org; Mon, 29 Apr 2013 11:51:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UWqMo-0005Vi-Q4 for qemu-devel@nongnu.org; Mon, 29 Apr 2013 11:51:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2369) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UWqMo-0005Vd-Gp for qemu-devel@nongnu.org; Mon, 29 Apr 2013 11:51:50 -0400 Message-ID: <517E9713.9010901@redhat.com> Date: Mon, 29 Apr 2013 09:51:47 -0600 From: Eric Blake MIME-Version: 1.0 References: <1366734308-11724-1-git-send-email-stefanha@redhat.com> <1366734308-11724-3-git-send-email-stefanha@redhat.com> <517B0690.7080904@redhat.com> <20130429072110.GA13488@stefanha-thinkpad.redhat.com> <517E3CE5.5030202@redhat.com> In-Reply-To: <517E3CE5.5030202@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2BFOIUKGAQIEVEDNNNXFQ" Subject: Re: [Qemu-devel] [PATCH 2/3] block: add block_backup QMP command List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Kevin Wolf , Fam Zheng , qemu-devel@nongnu.org, Ian Main , Stefan Hajnoczi , dietmar@proxmox.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) ------enig2BFOIUKGAQIEVEDNNNXFQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 04/29/2013 03:27 AM, Paolo Bonzini wrote: > Il 29/04/2013 09:21, Stefan Hajnoczi ha scritto: >>> I'd really love to see us change 'BlockJobInfo' to use an enum for >>> 'type', instead of its open-coded 'str'. Likewise, the block-job >>> related events in QMP/qmp-events.txt should be updated to refer to th= e >>> enum instead of also being open-coded 'str'. >> >> Since the block job QMP API has been in released I'm not sure changing= >> this is worthwhile. QEMU and libvirt would have to maintain >> compatibility so the code will just be duplicated. >=20 > I don't think this would change the actual data on the wire. However, > it would let libvirt know the supported block job types by introspectin= g > the enum. Until we have introspection, the point is moot. When we have introspection, libvirt would much rather see an enum than a 'str'. I see absolutely no back-compat problem in changing the code to be type-safe prior to the point that introspection is added. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org ------enig2BFOIUKGAQIEVEDNNNXFQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.13 (GNU/Linux) Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJRfpcTAAoJEKeha0olJ0NqovkH+wad4li1GZqIniXgpAC1GBTJ 5jZS1n5r5tT2jsVEuaFsXlUypYl5qXBWT9bMLN7ncWt3vsydNz8SbXhE5MfrmFc0 Y5y4CZjxDEHlt+Bj+L/fdp+j/LEniWBFZ7wcmlXRu6GmQetknFa2sulQhFieuDEM GM7e8ctm1mryA3OhHBVEieHm4cUKnpsXkPtXHzQqYTkzdczeZWGDJtr9BY5Fe9er /cKuJ70eP9YKfaH42HY6cPPaeDG6L+e1lAiC+MZCXKaPi48A2MD3ogH4fSd4u8zY zmR03s4hp6vfHtsGhMOyfBmPK/7k9b+8Ivl8yOQGVxgD06w08PzqKFA/Mg5hLg4= =8h7v -----END PGP SIGNATURE----- ------enig2BFOIUKGAQIEVEDNNNXFQ--