From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC 15/29] xen/arm: Don't hardcode VGIC informations Date: Mon, 29 Apr 2013 17:42:18 +0100 Message-ID: <517EA2EA.6000605@linaro.org> References: <1e2ebd306719ae2fbc37b050349a8299dc22b1b0.1367188423.git.julien.grall@linaro.org> <1367250117.3142.353.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1367250117.3142.353.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Anthony Perard , "patches@linaro.org" , Stefano Stabellini , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 04/29/2013 04:41 PM, Ian Campbell wrote: > On Mon, 2013-04-29 at 00:01 +0100, Julien Grall wrote: >> @@ -754,11 +759,21 @@ void gic_interrupt(struct cpu_user_regs *regs, int is_fiq) >> >> int gicv_setup(struct domain *d) >> { >> + /* TODO: Retrieve distributor and CPU guest base address from the >> + * guest DTS >> + * For the moment we use dom0 DTS > > FWIW I think what we will need here eventually is domctl's so the > toolstack can set this stuff explicitly to match the DT it generates, > not to pass the guest DTB to the hypervisor and parse it or anything > like that (maybe that's not what you were suggesting). I don't have a particular plan for parsing/generate the guest DTB. We can: 1) Replace the GIC base address in the guest DTB 2) Use the GIC base address found in the DTB I would prefer the second solution, and use the first when the node doesn't exist. I believe the guest DTB is currently appended to the kernel. So do we really need to create a new hypercall for this purpose? We can add some logic in the toolstack to take the kernel and the device tree in arguments and concatenate it. >> /* Number of ranks of interrupt registers for a domain */ >> @@ -79,7 +77,16 @@ int domain_vgic_init(struct domain *d) >> int i; >> >> d->arch.vgic.ctlr = 0; >> - d->arch.vgic.nr_lines = 32; >> + >> + /** > > Javadoc? ;-) Right. Bad habit :). I will replace by /*. -- Julien