From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC 20/29] xen/arm: Use the device tree to map the address range and IRQ to dom0 Date: Mon, 29 Apr 2013 18:30:18 +0100 Message-ID: <517EAE2A.3000802@linaro.org> References: <94e65fdf365c7d42c69ae7cc3e3fe10d94005d1d.1367188423.git.julien.grall@linaro.org> <1367251189.3142.365.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1367251189.3142.365.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Anthony Perard , "patches@linaro.org" , Stefano Stabellini , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 04/29/2013 04:59 PM, Ian Campbell wrote: >> @@ -30,6 +31,14 @@ static void __init parse_dom0_mem(const char *s) >> } >> custom_param("dom0_mem", parse_dom0_mem); >> >> +#define DEBUG_DT > > Did you mean to leave this on by default? Seems like it might be a bit > verbose? On the otherhand it would be nice to replace the "Map CS2 MMIO > regions 1:1 in the P2M ..." messages with something, and this seems like > it... No. I forgot to comment this line. I will fix it. >> + >> +static int parse_device_tree(struct domain *d) > > This is more like map_device_from_device_tree(d). I will rename the function. > Both minor nits, so: > Acked-by: Ian Campbell > -- Julien