From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sylwester Nawrocki Subject: Re: [PATCH 4/4] ARM: EXYNOS: remove parent device for hdmiphy clock Date: Mon, 29 Apr 2013 19:37:31 +0200 Message-ID: <517EAFDB.5020506@samsung.com> References: <1367247053-17105-1-git-send-email-rahul.sharma@samsung.com> <1367247053-17105-5-git-send-email-rahul.sharma@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mailout4.w1.samsung.com ([210.118.77.14]:57310 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757417Ab3D2Rhg (ORCPT ); Mon, 29 Apr 2013 13:37:36 -0400 Received: from eucpsbgm1.samsung.com (unknown [203.254.199.244]) by mailout4.w1.samsung.com (Oracle Communications Messaging Server 7u4-24.01(7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0MM10012O2AMMZD0@mailout4.w1.samsung.com> for linux-samsung-soc@vger.kernel.org; Mon, 29 Apr 2013 18:37:34 +0100 (BST) In-reply-to: Sender: linux-samsung-soc-owner@vger.kernel.org List-Id: linux-samsung-soc@vger.kernel.org To: Sean Paul , Rahul Sharma Cc: dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, InKi Dae , "r.sh.open" , "sw0312.kim" , sunil joshi Hi, On 04/29/2013 07:04 PM, Sean Paul wrote: > On Mon, Apr 29, 2013 at 10:50 AM, Rahul Sharma wrote: >> Hdmiphy clock flows from hdmiphy hw to hdmi ip and mixer. It is commonly >> accessed among hdmi and hdmiphy driver. During power cycle, each of these >> driver decrements the ref-count and ensures that last user disables the >> clock. Setting parrent device to none ensure that both the drivers gets >> access to the clock. >> > > This seems like the wrong solution. I think you should be trying to > isolate its usage to one driver, instead of removing devname. And files: arch/arm/mach-exynos/clock-exynos4.c arch/arm/mach-exynos/clock-exynos5.c are not existent in linux-next for some time already. Since 3.10 the common clock API driver is used. It also shows that very few people actually test their patches against -next... :( Regards, Sylwester > Sean > >> Signed-off-by: Rahul Sharma >> --- >> arch/arm/mach-exynos/clock-exynos4.c | 1 - >> arch/arm/mach-exynos/clock-exynos5.c | 1 - >> 2 files changed, 2 deletions(-) >> >> diff --git a/arch/arm/mach-exynos/clock-exynos4.c b/arch/arm/mach-exynos/clock-exynos4.c >> index 8a8468d..a43afcd 100644 >> --- a/arch/arm/mach-exynos/clock-exynos4.c >> +++ b/arch/arm/mach-exynos/clock-exynos4.c >> @@ -562,7 +562,6 @@ static struct clk exynos4_init_clocks_off[] = { >> .ctrlbit = (1 << 3), >> }, { >> .name = "hdmiphy", >> - .devname = "exynos4-hdmi", >> .enable = exynos4_clk_hdmiphy_ctrl, >> .ctrlbit = (1 << 0), >> }, { >> diff --git a/arch/arm/mach-exynos/clock-exynos5.c b/arch/arm/mach-exynos/clock-exynos5.c >> index b0ea31f..4f39027 100644 >> --- a/arch/arm/mach-exynos/clock-exynos5.c >> +++ b/arch/arm/mach-exynos/clock-exynos5.c >> @@ -690,7 +690,6 @@ static struct clk exynos5_init_clocks_off[] = { >> .ctrlbit = (1 << 6), >> }, { >> .name = "hdmiphy", >> - .devname = "exynos5-hdmi", >> .enable = exynos5_clk_hdmiphy_ctrl, >> .ctrlbit = (1 << 0), >> }, { >> -- >> 1.7.10.4