From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jim Fehlig <jfehlig@suse.com>
Subject: Re: libvirt, libxl and QDISKs
Date: Mon, 29 Apr 2013 15:00:16 -0600
Message-ID: <517EDF60.7000204@suse.com>
References: <5177EA93.7000403@eu.citrix.com>	<1366880153.20256.432.camel@zakaz.uk.xensource.com>	<CAFLBxZa04+NAow7p7sC0QOPGvVJJ8dSkakUdnM-C0AqHpoA2Sw@mail.gmail.com>	<1366889589.20256.510.camel@zakaz.uk.xensource.com>	<alpine.DEB.2.02.1304251249030.4180@kaball.uk.xensource.com>	<1366891065.20256.517.camel@zakaz.uk.xensource.com>	<51791DB1.9070903@eu.citrix.com>	<1366893802.20256.526.camel@zakaz.uk.xensource.com>	<51792E1F.3030005@eu.citrix.com>	<1366898215.20256.552.camel@zakaz.uk.xensource.com>	<5179D7F4.2080408@suse.com>	<alpine.DEB.2.02.1304261108000.4180@kaball.uk.xensource.com>	<517A6593.70906@invisiblethingslab.com>	<1366976452.3142.73.camel@zakaz.uk.xensource.com>
	<517A69FA.6080402@invisiblethingslab.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <517A69FA.6080402@invisiblethingslab.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Marek Marczykowski <marmarek@invisiblethingslab.com>
Cc: George Dunlap <George.Dunlap@eu.citrix.com>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, Dave Scott <Dave.Scott@eu.citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

Marek Marczykowski wrote:
> On 26.04.2013 13:40, Ian Campbell wrote:
>   
>> On Fri, 2013-04-26 at 12:31 +0100, Marek Marczykowski wrote:
>>     
>>> What about old good loop+phy based backend for file disk images? I don't want
>>> whole qemu in dom0 for PV domains, only for handling simple disk backend.
>>> Additionally sparse images + loop + phy + mount -o discard in domU makes the
>>> images "auto shrinking". Don't know if qemu is able to do this.
>>>       
>> IIRC the problem with loop+phy is that loop doesn't do O_DIRECT and
>> therefore your data isn't actually on the disk when you might think it
>> is, which can lead to filesystem corruption even if the f/s is doing
>> correct barriers.
>>
>>     
>>> Attached patch, which I currently use for that. If it is close to something
>>> that would be accepted, I will send it in new thread.
>>>       
>> I think you can use a block script for this (i.e. it does the loop
>> mount) and avoid patching libxl at all. That's what xend did at least...
>>     
>
> This also was solution I've evaluated, but libvirt developers don't want to
> hear about disk->script setting in official libvirt, so I still need to patch
> some library.

Good old loop+phy is supported by the legacy libvirt xen driver without
libvirt needing <disk><script /></disk>, generally by using <driver
name='file' />.

>  Choosing libxl seems to be more universal. Setting loop in libxl
> is also much faster than calling script for that.
> Perhaps I can rewrite this patch to allow the choice (LIBXL_DISK_BACKEND_LOOP)?
>   

With such a patch, libvirt could set the backend to
LIBXL_DISK_BACKEND_LOOP when <driver name='file'>, preserving loop+phy
backend setup done by the old toolstack.

Regards,
Jim