From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49048) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UX5Ai-0004GH-GE for qemu-devel@nongnu.org; Tue, 30 Apr 2013 03:40:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UX5Af-0000q1-EE for qemu-devel@nongnu.org; Tue, 30 Apr 2013 03:40:20 -0400 Received: from mail-1.de-punkt.de ([93.190.64.237]:54566) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UX5Af-0000pG-8O for qemu-devel@nongnu.org; Tue, 30 Apr 2013 03:40:17 -0400 Message-ID: <517F755D.10105@filoo.de> Date: Tue, 30 Apr 2013 09:40:13 +0200 From: Oliver Francke MIME-Version: 1.0 References: <5179293F.5010708@filoo.de> <20130425135142.GE3156@dhcp-200-207.str.redhat.com> <51793A17.5020303@filoo.de> <20130425173252.GD2486@dhcp-200-207.str.redhat.com> In-Reply-To: <20130425173252.GD2486@dhcp-200-207.str.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [Qemu-stable] Something broken with ceph-rbd images since couple of days ( after block-changes) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: "qemu-stable@nongnu.org" , "qemu@nongnu.org" , Stefan Priebe - Profihost AG Hi, took a snapshot of yesterdays "master" after "rbd: Fix use after free in=20 rbd_open()"... Works perfectly ;) Thank you very much for the bleeding fast reaction... Oliver. On 04/25/2013 07:32 PM, Kevin Wolf wrote: > Am 25.04.2013 um 19:25 hat Stefan Priebe - Profihost AG geschrieben: >> Ist this qemu 1.4.1? Did you received the patch? >> >> Stefan > No, this is actually about git master. Not sure why this was directed t= o > qemu-stable. > > Kevin > >> Am 25.04.2013 um 16:13 schrieb Oliver Francke : >> >>> Cool, >>> >>> thnx for the quick response... Not a C-coder any more, only wild-not-= too-bad guessing ;) >>> >>> Oliver. >>> >>> On 04/25/2013 03:51 PM, Kevin Wolf wrote: >>>> Am 25.04.2013 um 15:01 hat Oliver Francke geschrieben: >>>>> Hi, >>>>> >>>>> just encountered a bug while playing with latest aio_flush option i= n >>>>> ceph + qemu handling. >>>>> >>>>> I got a "invalid argument" even with "qemu-img info rbd:pool/image.= rbd". >>>>> >>>>> Perhaps qemu_rbd_open is called with wrong number of params >>>>> somewhere else after expanding params with "QDict *options" in >>>>> block/rbd.c line around line 444 with current master. >>>>> ( talking of qemu-54f106d) >>>>> >>>>> Just as a quick note ;) >>>> Thanks for the report, Oliver. The problem is the qemu_opts_del() in >>>> line 481, which is too early. This frees the filename already when i= t's >>>> still needed for the parsing. >>>> >>>> I'm copying qemu-devel and Josh, just so everyone is informed. I'll = try >>>> to send a patch myself in a few minutes. >>>> >>>> Kevin >>> >>> --=20 >>> >>> Oliver Francke >>> >>> filoo GmbH >>> Moltkestra=DFe 25a >>> 33330 G=FCtersloh >>> HRB4355 AG G=FCtersloh >>> >>> Gesch=E4ftsf=FChrer: S.Grewing | J.Rehp=F6hler | C.Kunz >>> >>> Folgen Sie uns auf Twitter: http://twitter.com/filoogmbh >>> >>> --=20 Oliver Francke filoo GmbH Moltkestra=DFe 25a 33330 G=FCtersloh HRB4355 AG G=FCtersloh Gesch=E4ftsf=FChrer: S.Grewing | J.Rehp=F6hler | C.Kunz Folgen Sie uns auf Twitter: http://twitter.com/filoogmbh