From mboxrd@z Thu Jan  1 00:00:00 1970
From: Michal Kazior <michal.kazior@tieto.com>
Date: Tue, 30 Apr 2013 09:51:42 +0200
Subject: [ath9k-devel] [PATCH 6/6] ath10k: cleanup ath10k_pci_stop_intr()
In-Reply-To: <87zjwglbxc.fsf@kamboji.qca.qualcomm.com>
References: <1366962748-6660-1-git-send-email-michal.kazior@tieto.com>
	<1366962748-6660-7-git-send-email-michal.kazior@tieto.com>
	<87zjwglbxc.fsf@kamboji.qca.qualcomm.com>
Message-ID: <517F780E.9040800@tieto.com>
List-Id: <ath9k-devel.lists.ath9k.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: ath9k-devel@lists.ath9k.org

On 30/04/13 09:23, Kalle Valo wrote:
> Michal Kazior <michal.kazior@tieto.com> writes:
>
>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>
> [...]
>
>> +	/* There's at least one interrupt irregardless whether its legacy INTR
>> +	 * or MSI or MSI-X */
>> +	for (i = 0; i < min(1, ar_pci->num_msi_intrs); i++)
>> +		free_irq(ar_pci->pdev->irq + i, ar);
>
> I'm not sure about this. If num_msi_intrs is 5 we still free only the
> first irq? Did I understood this correctly?

Oh my! This is supposed to be max(). Good catch, thanks!


-- Pozdrawiam / Best regards, Michal Kazior.