From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38637) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UX8x6-0006jA-M3 for qemu-devel@nongnu.org; Tue, 30 Apr 2013 07:42:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UX8x4-0003kk-NI for qemu-devel@nongnu.org; Tue, 30 Apr 2013 07:42:32 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35442 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UX8x4-0003kZ-Gx for qemu-devel@nongnu.org; Tue, 30 Apr 2013 07:42:30 -0400 Message-ID: <517FAE24.1040000@suse.de> Date: Tue, 30 Apr 2013 13:42:28 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1367303766-9526-1-git-send-email-john.rigby@linaro.org> In-Reply-To: <1367303766-9526-1-git-send-email-john.rigby@linaro.org> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 01/12] ARM: Export cpu_env List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Rigby , Alexander Graf Cc: Peter Maydell , qemu-devel Am 30.04.2013 08:36, schrieb John Rigby: > From: Alexander Graf >=20 > The cpu_env tcg variable will be used by both the AArch32 and AArch64 > handling code. Unstaticify it, so that both sides can make use of it. >=20 > Signed-off-by: Alexander Graf John, when you submit patches, you need to add your Signed-off-by! http://wiki.qemu.org/Contribute/SubmitAPatch This patch is not reviewable in context because the messages are not threaded together - git-send-email does that by default for you. > --- > target-arm/translate.c | 2 +- > target-arm/translate.h | 2 ++ > 2 files changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/target-arm/translate.c b/target-arm/translate.c > index 675773a..36537bd 100644 > --- a/target-arm/translate.c > +++ b/target-arm/translate.c > @@ -59,7 +59,7 @@ static uint32_t gen_opc_condexec_bits[OPC_BUF_SIZE]; > #define DISAS_WFI 4 > #define DISAS_SWI 5 > =20 > -static TCGv_ptr cpu_env; > +TCGv_ptr cpu_env; > /* We reuse the same 64-bit temporaries for efficiency. */ > static TCGv_i64 cpu_V0, cpu_V1, cpu_M0; > static TCGv_i32 cpu_R[16]; > diff --git a/target-arm/translate.h b/target-arm/translate.h > index e727bc6..8ba1433 100644 > --- a/target-arm/translate.h > +++ b/target-arm/translate.h > @@ -24,4 +24,6 @@ typedef struct DisasContext { > int vec_stride; > } DisasContext; > =20 > +extern TCGv_ptr cpu_env; > + > #endif /* TARGET_ARM_TRANSLATE_H */ Alex, have you checked whether the variable can be placed in qom/cpu.c instead once for all targets? I'd hope that would be possible with an appropriate typedef (since target_long size etc. are unknown there). Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg