From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Gerlando Falauto <gerlando.falauto@keymile.com>
Cc: netdev@vger.kernel.org, jon.maloy@ericsson.com,
erik.hugne@ericsson.com, ying.xue@windriver.com,
holger.brunck@keymile.com
Subject: Re: [PATCH v3 1/3] tipc: cosmetic: clean up comments
Date: Tue, 30 Apr 2013 15:54:01 +0400 [thread overview]
Message-ID: <517FB0D9.1070404@cogentembedded.com> (raw)
In-Reply-To: <1367307199-10577-1-git-send-email-gerlando.falauto@keymile.com>
Hello.
On 30-04-2013 11:33, Gerlando Falauto wrote:
> Signed-off-by: Gerlando Falauto <gerlando.falauto@keymile.com>
> ---
> Changes from v2:
> * Split cosmetic from functional changes
> net/tipc/bcast.c | 13 +++++++------
> 1 file changed, 7 insertions(+), 6 deletions(-)
> diff --git a/net/tipc/bcast.c b/net/tipc/bcast.c
> index 2655c9f..8438e01 100644
> --- a/net/tipc/bcast.c
> +++ b/net/tipc/bcast.c
> @@ -584,8 +584,7 @@ static int tipc_bcbearer_send(struct sk_buff *buf,
> {
> int bp_index;
>
> - /*
> - * Prepare broadcast link message for reliable transmission,
> + /* Prepare broadcast link message for reliable transmission,
> * if first time trying to send it;
> * preparation is skipped for broadcast link protocol messages
> * since they are sent in an unreliable manner and don't need it
> @@ -613,11 +612,12 @@ static int tipc_bcbearer_send(struct sk_buff *buf,
> struct tipc_bearer *s = bcbearer->bpairs[bp_index].secondary;
>
> if (!p)
> - break; /* no more bearers to try */
> + break; /* No more bearers to try */
>
> - tipc_nmap_diff(&bcbearer->remains, &p->nodes, &bcbearer->remains_new);
> + tipc_nmap_diff(&bcbearer->remains, &p->nodes,
> + &bcbearer->remains_new);
It apeears you nopt only cleaning up comments in this patch but you don't
mention this change in the changelog...
WBR, Sergei
next prev parent reply other threads:[~2013-04-30 11:54 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 14:13 [PATCH v2 1/2] tipc: tipc_bcbearer_send(): simplify bearer selection Gerlando Falauto
2013-04-29 14:13 ` [PATCH v2 2/2] tipc: pskb_copy() buffers when sending on more than one bearer Gerlando Falauto
2013-04-29 19:45 ` David Miller
2013-04-29 19:44 ` [PATCH v2 1/2] tipc: tipc_bcbearer_send(): simplify bearer selection David Miller
2013-04-30 7:33 ` [PATCH v3 1/3] tipc: cosmetic: clean up comments Gerlando Falauto
2013-04-30 7:33 ` [PATCH v3 2/3] tipc: tipc_bcbearer_send(): simplify bearer selection Gerlando Falauto
2013-04-30 7:33 ` [PATCH v3 3/3] tipc: pskb_copy() buffers when sending on more than one bearer Gerlando Falauto
2013-04-30 11:54 ` Sergei Shtylyov [this message]
2013-04-30 19:07 ` [PATCH v3 1/3] tipc: cosmetic: clean up comments David Miller
2013-05-01 7:37 ` Gerlando Falauto
2013-05-01 16:18 ` Sergei Shtylyov
2013-05-01 16:41 ` [PATCH v3b 1/3] tipc: cosmetic: clean up comments and break a long line Gerlando Falauto
2013-05-01 17:16 ` David Miller
2013-05-01 17:35 ` Gerlando Falauto
2013-05-01 17:43 ` David Miller
2013-05-01 17:56 ` Gerlando Falauto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517FB0D9.1070404@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=erik.hugne@ericsson.com \
--cc=gerlando.falauto@keymile.com \
--cc=holger.brunck@keymile.com \
--cc=jon.maloy@ericsson.com \
--cc=netdev@vger.kernel.org \
--cc=ying.xue@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.