From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42381) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UX9EY-0004Un-P6 for qemu-devel@nongnu.org; Tue, 30 Apr 2013 08:00:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UX9EX-0001Bv-9J for qemu-devel@nongnu.org; Tue, 30 Apr 2013 08:00:34 -0400 Received: from cantor2.suse.de ([195.135.220.15]:36891 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UX9EW-0001Bl-WA for qemu-devel@nongnu.org; Tue, 30 Apr 2013 08:00:33 -0400 Message-ID: <517FB25F.7070501@suse.de> Date: Tue, 30 Apr 2013 14:00:31 +0200 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1367303766-9526-1-git-send-email-john.rigby@linaro.org> <517FAE24.1040000@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2 01/12] ARM: Export cpu_env List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: Peter Crosthwaite , Peter Maydell , John Rigby , qemu-devel , "Edgar E. Iglesias" Am 30.04.2013 13:54, schrieb Alexander Graf: >=20 > Am 30.04.2013 um 13:42 schrieb Andreas F=C3=A4rber : >=20 >> Am 30.04.2013 08:36, schrieb John Rigby: >>> From: Alexander Graf >>> >>> The cpu_env tcg variable will be used by both the AArch32 and AArch64 >>> handling code. Unstaticify it, so that both sides can make use of it. >>> >>> Signed-off-by: Alexander Graf [...] >>> --- >>> target-arm/translate.c | 2 +- >>> target-arm/translate.h | 2 ++ >>> 2 files changed, 3 insertions(+), 1 deletion(-) >>> >>> diff --git a/target-arm/translate.c b/target-arm/translate.c >>> index 675773a..36537bd 100644 >>> --- a/target-arm/translate.c >>> +++ b/target-arm/translate.c >>> @@ -59,7 +59,7 @@ static uint32_t gen_opc_condexec_bits[OPC_BUF_SIZE]= ; >>> #define DISAS_WFI 4 >>> #define DISAS_SWI 5 >>> >>> -static TCGv_ptr cpu_env; >>> +TCGv_ptr cpu_env; >>> /* We reuse the same 64-bit temporaries for efficiency. */ >>> static TCGv_i64 cpu_V0, cpu_V1, cpu_M0; >>> static TCGv_i32 cpu_R[16]; >>> diff --git a/target-arm/translate.h b/target-arm/translate.h >>> index e727bc6..8ba1433 100644 >>> --- a/target-arm/translate.h >>> +++ b/target-arm/translate.h >>> @@ -24,4 +24,6 @@ typedef struct DisasContext { >>> int vec_stride; >>> } DisasContext; >>> >>> +extern TCGv_ptr cpu_env; >>> + >>> #endif /* TARGET_ARM_TRANSLATE_H */ >> >> Alex, have you checked whether the variable can be placed in qom/cpu.c >> instead once for all targets? I'd hope that would be possible with an >> appropriate typedef (since target_long size etc. are unknown there). >=20 > I would prefer to keep the translation context separate from the execut= ion context. Not sure if you understood my point? Exposing cpu_env from target-arm would seem to torpedo our efforts to link target-arm and, e.g., target-microblaze together, since they all have cpu_env. I don't really care if it's qom/cpu.c or tcg/shared.c or renaming to arm_cpu_env. :) Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg