* linux-next build error (at91) - use of bool in mach/arch.h @ 2013-04-30 9:33 ` Nicolas Ferre 0 siblings, 0 replies; 16+ messages in thread From: Nicolas Ferre @ 2013-04-30 9:33 UTC (permalink / raw) To: linux-arm-kernel Hi, Today I discovered an issue while building linux-next for at91: CC arch/arm/mach-at91/at91sam9260_devices.o In file included from /home/nferre/dev/lnx_buid_test/arch/arm/mach-at91/at91sam9260_devices.c:12:0: /home/nferre/dev/lnx_buid_test/arch/arm/include/asm/mach/arch.h:46:2: error: expected specifier-qualifier-list before ?bool? It also applies to all non-DT at91 platforms (~ 6 machines). It seems to be caused by inclusion of commmit 4dbfa9a25367cfa91aec0e56d75a6905d3242cd3 (ARM: Enable selection of SMP operations at boot time) and its use of the "bool" type. In fact, we include asm/mach/arch.h file in our at91xxx_devices.c files and we include it as the first include directive. So, I am wondering if the best correction is to add the types.h header file in the asm/mach/arch.h file, like this: --- a/arch/arm/include/asm/mach/arch.h +++ b/arch/arm/include/asm/mach/arch.h @@ -8,6 +8,8 @@ * published by the Free Software Foundation. */ +#include <linux/types.h> + #ifndef __ASSEMBLY__ struct tag; or if a better option would be to re-arrange the include directives in various at91xxx_devices.c files? Thanks, bye, -- Nicolas Ferre ^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next build error (at91) - use of bool in mach/arch.h @ 2013-04-30 9:33 ` Nicolas Ferre 0 siblings, 0 replies; 16+ messages in thread From: Nicolas Ferre @ 2013-04-30 9:33 UTC (permalink / raw) To: Marc Zyngier, linux-arm-kernel, Russell King - ARM Linux, Jon Medhurst, Stefano Stabellini Cc: Linux Kernel list, Jean-Christophe PLAGNIOL-VILLARD, Ludovic Desroches, Nicolas Pitre Hi, Today I discovered an issue while building linux-next for at91: CC arch/arm/mach-at91/at91sam9260_devices.o In file included from /home/nferre/dev/lnx_buid_test/arch/arm/mach-at91/at91sam9260_devices.c:12:0: /home/nferre/dev/lnx_buid_test/arch/arm/include/asm/mach/arch.h:46:2: error: expected specifier-qualifier-list before ‘bool’ It also applies to all non-DT at91 platforms (~ 6 machines). It seems to be caused by inclusion of commmit 4dbfa9a25367cfa91aec0e56d75a6905d3242cd3 (ARM: Enable selection of SMP operations at boot time) and its use of the "bool" type. In fact, we include asm/mach/arch.h file in our at91xxx_devices.c files and we include it as the first include directive. So, I am wondering if the best correction is to add the types.h header file in the asm/mach/arch.h file, like this: --- a/arch/arm/include/asm/mach/arch.h +++ b/arch/arm/include/asm/mach/arch.h @@ -8,6 +8,8 @@ * published by the Free Software Foundation. */ +#include <linux/types.h> + #ifndef __ASSEMBLY__ struct tag; or if a better option would be to re-arrange the include directives in various at91xxx_devices.c files? Thanks, bye, -- Nicolas Ferre ^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next build error (at91) - use of bool in mach/arch.h 2013-04-30 9:33 ` Nicolas Ferre @ 2013-04-30 9:39 ` Geert Uytterhoeven -1 siblings, 0 replies; 16+ messages in thread From: Geert Uytterhoeven @ 2013-04-30 9:39 UTC (permalink / raw) To: linux-arm-kernel On Tue, Apr 30, 2013 at 11:33 AM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote: > So, I am wondering if the best correction is to add the types.h header file > in the asm/mach/arch.h file, like this: > > --- a/arch/arm/include/asm/mach/arch.h > +++ b/arch/arm/include/asm/mach/arch.h > @@ -8,6 +8,8 @@ > * published by the Free Software Foundation. > */ > > +#include <linux/types.h> > + > #ifndef __ASSEMBLY__ > > struct tag; > > or if a better option would be to re-arrange the include directives in > various at91xxx_devices.c files? Include files should be self-contained, so asm/mach/arch.h is the right place. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next build error (at91) - use of bool in mach/arch.h @ 2013-04-30 9:39 ` Geert Uytterhoeven 0 siblings, 0 replies; 16+ messages in thread From: Geert Uytterhoeven @ 2013-04-30 9:39 UTC (permalink / raw) To: Nicolas Ferre Cc: Marc Zyngier, linux-arm-kernel, Russell King - ARM Linux, Jon Medhurst, Stefano Stabellini, Linux Kernel list, Jean-Christophe PLAGNIOL-VILLARD, Ludovic Desroches, Nicolas Pitre On Tue, Apr 30, 2013 at 11:33 AM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote: > So, I am wondering if the best correction is to add the types.h header file > in the asm/mach/arch.h file, like this: > > --- a/arch/arm/include/asm/mach/arch.h > +++ b/arch/arm/include/asm/mach/arch.h > @@ -8,6 +8,8 @@ > * published by the Free Software Foundation. > */ > > +#include <linux/types.h> > + > #ifndef __ASSEMBLY__ > > struct tag; > > or if a better option would be to re-arrange the include directives in > various at91xxx_devices.c files? Include files should be self-contained, so asm/mach/arch.h is the right place. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next build error (at91) - use of bool in mach/arch.h 2013-04-30 9:39 ` Geert Uytterhoeven @ 2013-04-30 11:58 ` Stefano Stabellini -1 siblings, 0 replies; 16+ messages in thread From: Stefano Stabellini @ 2013-04-30 11:58 UTC (permalink / raw) To: linux-arm-kernel On Tue, 30 Apr 2013, Geert Uytterhoeven wrote: > On Tue, Apr 30, 2013 at 11:33 AM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote: > > So, I am wondering if the best correction is to add the types.h header file > > in the asm/mach/arch.h file, like this: > > > > --- a/arch/arm/include/asm/mach/arch.h > > +++ b/arch/arm/include/asm/mach/arch.h > > @@ -8,6 +8,8 @@ > > * published by the Free Software Foundation. > > */ > > > > +#include <linux/types.h> > > + > > #ifndef __ASSEMBLY__ > > > > struct tag; > > > > or if a better option would be to re-arrange the include directives in > > various at91xxx_devices.c files? > > Include files should be self-contained, so asm/mach/arch.h is the right place. Nicolas, are you happy to come up with a proper patch to fix the issue? ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next build error (at91) - use of bool in mach/arch.h @ 2013-04-30 11:58 ` Stefano Stabellini 0 siblings, 0 replies; 16+ messages in thread From: Stefano Stabellini @ 2013-04-30 11:58 UTC (permalink / raw) To: Geert Uytterhoeven Cc: Nicolas Ferre, Marc Zyngier, linux-arm-kernel, Russell King - ARM Linux, Jon Medhurst, Stefano Stabellini, Linux Kernel list, Jean-Christophe PLAGNIOL-VILLARD, Ludovic Desroches, Nicolas Pitre On Tue, 30 Apr 2013, Geert Uytterhoeven wrote: > On Tue, Apr 30, 2013 at 11:33 AM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote: > > So, I am wondering if the best correction is to add the types.h header file > > in the asm/mach/arch.h file, like this: > > > > --- a/arch/arm/include/asm/mach/arch.h > > +++ b/arch/arm/include/asm/mach/arch.h > > @@ -8,6 +8,8 @@ > > * published by the Free Software Foundation. > > */ > > > > +#include <linux/types.h> > > + > > #ifndef __ASSEMBLY__ > > > > struct tag; > > > > or if a better option would be to re-arrange the include directives in > > various at91xxx_devices.c files? > > Include files should be self-contained, so asm/mach/arch.h is the right place. Nicolas, are you happy to come up with a proper patch to fix the issue? ^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next build error (at91) - use of bool in mach/arch.h 2013-04-30 11:58 ` Stefano Stabellini @ 2013-04-30 12:40 ` Nicolas Ferre -1 siblings, 0 replies; 16+ messages in thread From: Nicolas Ferre @ 2013-04-30 12:40 UTC (permalink / raw) To: linux-arm-kernel On 04/30/2013 01:58 PM, Stefano Stabellini : > On Tue, 30 Apr 2013, Geert Uytterhoeven wrote: >> On Tue, Apr 30, 2013 at 11:33 AM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote: >>> So, I am wondering if the best correction is to add the types.h header file >>> in the asm/mach/arch.h file, like this: >>> >>> --- a/arch/arm/include/asm/mach/arch.h >>> +++ b/arch/arm/include/asm/mach/arch.h >>> @@ -8,6 +8,8 @@ >>> * published by the Free Software Foundation. >>> */ >>> >>> +#include <linux/types.h> >>> + >>> #ifndef __ASSEMBLY__ >>> >>> struct tag; >>> >>> or if a better option would be to re-arrange the include directives in >>> various at91xxx_devices.c files? >> >> Include files should be self-contained, so asm/mach/arch.h is the right place. > > Nicolas, > are you happy to come up with a proper patch to fix the issue? Yep, sent now. Bye, -- Nicolas Ferre ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next build error (at91) - use of bool in mach/arch.h @ 2013-04-30 12:40 ` Nicolas Ferre 0 siblings, 0 replies; 16+ messages in thread From: Nicolas Ferre @ 2013-04-30 12:40 UTC (permalink / raw) To: Stefano Stabellini Cc: Geert Uytterhoeven, Marc Zyngier, linux-arm-kernel, Russell King - ARM Linux, Jon Medhurst, Linux Kernel list, Jean-Christophe PLAGNIOL-VILLARD, Ludovic Desroches, Nicolas Pitre On 04/30/2013 01:58 PM, Stefano Stabellini : > On Tue, 30 Apr 2013, Geert Uytterhoeven wrote: >> On Tue, Apr 30, 2013 at 11:33 AM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote: >>> So, I am wondering if the best correction is to add the types.h header file >>> in the asm/mach/arch.h file, like this: >>> >>> --- a/arch/arm/include/asm/mach/arch.h >>> +++ b/arch/arm/include/asm/mach/arch.h >>> @@ -8,6 +8,8 @@ >>> * published by the Free Software Foundation. >>> */ >>> >>> +#include <linux/types.h> >>> + >>> #ifndef __ASSEMBLY__ >>> >>> struct tag; >>> >>> or if a better option would be to re-arrange the include directives in >>> various at91xxx_devices.c files? >> >> Include files should be self-contained, so asm/mach/arch.h is the right place. > > Nicolas, > are you happy to come up with a proper patch to fix the issue? Yep, sent now. Bye, -- Nicolas Ferre ^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next build error (at91) - use of bool in mach/arch.h 2013-04-30 11:58 ` Stefano Stabellini @ 2013-04-30 15:15 ` Nicolas Pitre -1 siblings, 0 replies; 16+ messages in thread From: Nicolas Pitre @ 2013-04-30 15:15 UTC (permalink / raw) To: linux-arm-kernel On Tue, 30 Apr 2013, Stefano Stabellini wrote: > On Tue, 30 Apr 2013, Geert Uytterhoeven wrote: > > On Tue, Apr 30, 2013 at 11:33 AM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote: > > > So, I am wondering if the best correction is to add the types.h header file > > > in the asm/mach/arch.h file, like this: > > > > > > --- a/arch/arm/include/asm/mach/arch.h > > > +++ b/arch/arm/include/asm/mach/arch.h > > > @@ -8,6 +8,8 @@ > > > * published by the Free Software Foundation. > > > */ > > > > > > +#include <linux/types.h> > > > + > > > #ifndef __ASSEMBLY__ > > > > > > struct tag; > > > > > > or if a better option would be to re-arrange the include directives in > > > various at91xxx_devices.c files? > > > > Include files should be self-contained, so asm/mach/arch.h is the right place. > > Nicolas, > are you happy to come up with a proper patch to fix the issue? I'd prefer if you just folded the above include into the original patch, unless this has been pulled already. Nicolas ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next build error (at91) - use of bool in mach/arch.h @ 2013-04-30 15:15 ` Nicolas Pitre 0 siblings, 0 replies; 16+ messages in thread From: Nicolas Pitre @ 2013-04-30 15:15 UTC (permalink / raw) To: Stefano Stabellini Cc: Geert Uytterhoeven, Nicolas Ferre, Marc Zyngier, linux-arm-kernel, Russell King - ARM Linux, Jon Medhurst, Linux Kernel list, Jean-Christophe PLAGNIOL-VILLARD, Ludovic Desroches On Tue, 30 Apr 2013, Stefano Stabellini wrote: > On Tue, 30 Apr 2013, Geert Uytterhoeven wrote: > > On Tue, Apr 30, 2013 at 11:33 AM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote: > > > So, I am wondering if the best correction is to add the types.h header file > > > in the asm/mach/arch.h file, like this: > > > > > > --- a/arch/arm/include/asm/mach/arch.h > > > +++ b/arch/arm/include/asm/mach/arch.h > > > @@ -8,6 +8,8 @@ > > > * published by the Free Software Foundation. > > > */ > > > > > > +#include <linux/types.h> > > > + > > > #ifndef __ASSEMBLY__ > > > > > > struct tag; > > > > > > or if a better option would be to re-arrange the include directives in > > > various at91xxx_devices.c files? > > > > Include files should be self-contained, so asm/mach/arch.h is the right place. > > Nicolas, > are you happy to come up with a proper patch to fix the issue? I'd prefer if you just folded the above include into the original patch, unless this has been pulled already. Nicolas ^ permalink raw reply [flat|nested] 16+ messages in thread
* linux-next build error (at91) - use of bool in mach/arch.h 2013-04-30 15:15 ` Nicolas Pitre @ 2013-04-30 15:59 ` Stefano Stabellini -1 siblings, 0 replies; 16+ messages in thread From: Stefano Stabellini @ 2013-04-30 15:59 UTC (permalink / raw) To: linux-arm-kernel On Tue, 30 Apr 2013, Nicolas Pitre wrote: > On Tue, 30 Apr 2013, Stefano Stabellini wrote: > > > On Tue, 30 Apr 2013, Geert Uytterhoeven wrote: > > > On Tue, Apr 30, 2013 at 11:33 AM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote: > > > > So, I am wondering if the best correction is to add the types.h header file > > > > in the asm/mach/arch.h file, like this: > > > > > > > > --- a/arch/arm/include/asm/mach/arch.h > > > > +++ b/arch/arm/include/asm/mach/arch.h > > > > @@ -8,6 +8,8 @@ > > > > * published by the Free Software Foundation. > > > > */ > > > > > > > > +#include <linux/types.h> > > > > + > > > > #ifndef __ASSEMBLY__ > > > > > > > > struct tag; > > > > > > > > or if a better option would be to re-arrange the include directives in > > > > various at91xxx_devices.c files? > > > > > > Include files should be self-contained, so asm/mach/arch.h is the right place. > > > > Nicolas, > > are you happy to come up with a proper patch to fix the issue? > > I'd prefer if you just folded the above include into the original patch, > unless this has been pulled already. No, I'll exploit the opportunity to resend the patch series and issue a PULL request for the arm-soc tree. ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: linux-next build error (at91) - use of bool in mach/arch.h @ 2013-04-30 15:59 ` Stefano Stabellini 0 siblings, 0 replies; 16+ messages in thread From: Stefano Stabellini @ 2013-04-30 15:59 UTC (permalink / raw) To: Nicolas Pitre Cc: Stefano Stabellini, Geert Uytterhoeven, Nicolas Ferre, Marc Zyngier, linux-arm-kernel, Russell King - ARM Linux, Jon Medhurst, Linux Kernel list, Jean-Christophe PLAGNIOL-VILLARD, Ludovic Desroches On Tue, 30 Apr 2013, Nicolas Pitre wrote: > On Tue, 30 Apr 2013, Stefano Stabellini wrote: > > > On Tue, 30 Apr 2013, Geert Uytterhoeven wrote: > > > On Tue, Apr 30, 2013 at 11:33 AM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote: > > > > So, I am wondering if the best correction is to add the types.h header file > > > > in the asm/mach/arch.h file, like this: > > > > > > > > --- a/arch/arm/include/asm/mach/arch.h > > > > +++ b/arch/arm/include/asm/mach/arch.h > > > > @@ -8,6 +8,8 @@ > > > > * published by the Free Software Foundation. > > > > */ > > > > > > > > +#include <linux/types.h> > > > > + > > > > #ifndef __ASSEMBLY__ > > > > > > > > struct tag; > > > > > > > > or if a better option would be to re-arrange the include directives in > > > > various at91xxx_devices.c files? > > > > > > Include files should be self-contained, so asm/mach/arch.h is the right place. > > > > Nicolas, > > are you happy to come up with a proper patch to fix the issue? > > I'd prefer if you just folded the above include into the original patch, > unless this has been pulled already. No, I'll exploit the opportunity to resend the patch series and issue a PULL request for the arm-soc tree. ^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] ARM: add the "bool" type definition to asm/mach/arch.h 2013-04-30 9:33 ` Nicolas Ferre @ 2013-04-30 12:38 ` Nicolas Ferre -1 siblings, 0 replies; 16+ messages in thread From: Nicolas Ferre @ 2013-04-30 12:38 UTC (permalink / raw) To: linux-arm-kernel Addition of boolean field to machine_desc structure in commit 4dbfa9a25367cfa91aec0e56d75a6905d3242cd3 (ARM: Enable selection of SMP operations at boot time) was triggering compilation errors like: CC arch/arm/mach-at91/at91sam9260_devices.o In file included from arch/arm/mach-at91/at91sam9260_devices.c:12:0: arch/arm/include/asm/mach/arch.h:46:2: error: expected specifier-qualifier-list before "bool" So, we add the definition of "bool" by including the linux/types.h file to asm/mach/arch.h and make it self-contained. Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> --- arch/arm/include/asm/mach/arch.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/include/asm/mach/arch.h b/arch/arm/include/asm/mach/arch.h index af8c54c..75bf079 100644 --- a/arch/arm/include/asm/mach/arch.h +++ b/arch/arm/include/asm/mach/arch.h @@ -8,6 +8,8 @@ * published by the Free Software Foundation. */ +#include <linux/types.h> + #ifndef __ASSEMBLY__ struct tag; -- 1.8.0 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] ARM: add the "bool" type definition to asm/mach/arch.h @ 2013-04-30 12:38 ` Nicolas Ferre 0 siblings, 0 replies; 16+ messages in thread From: Nicolas Ferre @ 2013-04-30 12:38 UTC (permalink / raw) To: linux-arm-kernel, Russell King, tixy, stefano.stabellini Cc: linux-kernel, Marc Zyngier, nicolas.pitre, Ludovic Desroches, Jean-Christophe PLAGNIOL-VILLARD, Nicolas Ferre Addition of boolean field to machine_desc structure in commit 4dbfa9a25367cfa91aec0e56d75a6905d3242cd3 (ARM: Enable selection of SMP operations at boot time) was triggering compilation errors like: CC arch/arm/mach-at91/at91sam9260_devices.o In file included from arch/arm/mach-at91/at91sam9260_devices.c:12:0: arch/arm/include/asm/mach/arch.h:46:2: error: expected specifier-qualifier-list before "bool" So, we add the definition of "bool" by including the linux/types.h file to asm/mach/arch.h and make it self-contained. Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> --- arch/arm/include/asm/mach/arch.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/include/asm/mach/arch.h b/arch/arm/include/asm/mach/arch.h index af8c54c..75bf079 100644 --- a/arch/arm/include/asm/mach/arch.h +++ b/arch/arm/include/asm/mach/arch.h @@ -8,6 +8,8 @@ * published by the Free Software Foundation. */ +#include <linux/types.h> + #ifndef __ASSEMBLY__ struct tag; -- 1.8.0 ^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] ARM: add the "bool" type definition to asm/mach/arch.h 2013-04-30 12:38 ` Nicolas Ferre @ 2013-04-30 14:05 ` Stefano Stabellini -1 siblings, 0 replies; 16+ messages in thread From: Stefano Stabellini @ 2013-04-30 14:05 UTC (permalink / raw) To: linux-arm-kernel On Tue, 30 Apr 2013, Nicolas Ferre wrote: > Addition of boolean field to machine_desc structure in commit > 4dbfa9a25367cfa91aec0e56d75a6905d3242cd3 (ARM: Enable selection of > SMP operations at boot time) was triggering compilation errors like: > > CC arch/arm/mach-at91/at91sam9260_devices.o > In file included from arch/arm/mach-at91/at91sam9260_devices.c:12:0: > arch/arm/include/asm/mach/arch.h:46:2: error: expected specifier-qualifier-list before "bool" > > So, we add the definition of "bool" by including the linux/types.h > file to asm/mach/arch.h and make it self-contained. > > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > arch/arm/include/asm/mach/arch.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/include/asm/mach/arch.h b/arch/arm/include/asm/mach/arch.h > index af8c54c..75bf079 100644 > --- a/arch/arm/include/asm/mach/arch.h > +++ b/arch/arm/include/asm/mach/arch.h > @@ -8,6 +8,8 @@ > * published by the Free Software Foundation. > */ > > +#include <linux/types.h> > + > #ifndef __ASSEMBLY__ > > struct tag; > -- > 1.8.0 > ^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] ARM: add the "bool" type definition to asm/mach/arch.h @ 2013-04-30 14:05 ` Stefano Stabellini 0 siblings, 0 replies; 16+ messages in thread From: Stefano Stabellini @ 2013-04-30 14:05 UTC (permalink / raw) To: Nicolas Ferre Cc: linux-arm-kernel@lists.infradead.org, Russell King, tixy@linaro.org, Stefano Stabellini, linux-kernel@vger.kernel.org, Marc Zyngier, nicolas.pitre@linaro.org, Ludovic Desroches, Jean-Christophe PLAGNIOL-VILLARD On Tue, 30 Apr 2013, Nicolas Ferre wrote: > Addition of boolean field to machine_desc structure in commit > 4dbfa9a25367cfa91aec0e56d75a6905d3242cd3 (ARM: Enable selection of > SMP operations at boot time) was triggering compilation errors like: > > CC arch/arm/mach-at91/at91sam9260_devices.o > In file included from arch/arm/mach-at91/at91sam9260_devices.c:12:0: > arch/arm/include/asm/mach/arch.h:46:2: error: expected specifier-qualifier-list before "bool" > > So, we add the definition of "bool" by including the linux/types.h > file to asm/mach/arch.h and make it self-contained. > > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> Acked-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com> > arch/arm/include/asm/mach/arch.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/arm/include/asm/mach/arch.h b/arch/arm/include/asm/mach/arch.h > index af8c54c..75bf079 100644 > --- a/arch/arm/include/asm/mach/arch.h > +++ b/arch/arm/include/asm/mach/arch.h > @@ -8,6 +8,8 @@ > * published by the Free Software Foundation. > */ > > +#include <linux/types.h> > + > #ifndef __ASSEMBLY__ > > struct tag; > -- > 1.8.0 > ^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2013-04-30 15:59 UTC | newest] Thread overview: 16+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2013-04-30 9:33 linux-next build error (at91) - use of bool in mach/arch.h Nicolas Ferre 2013-04-30 9:33 ` Nicolas Ferre 2013-04-30 9:39 ` Geert Uytterhoeven 2013-04-30 9:39 ` Geert Uytterhoeven 2013-04-30 11:58 ` Stefano Stabellini 2013-04-30 11:58 ` Stefano Stabellini 2013-04-30 12:40 ` Nicolas Ferre 2013-04-30 12:40 ` Nicolas Ferre 2013-04-30 15:15 ` Nicolas Pitre 2013-04-30 15:15 ` Nicolas Pitre 2013-04-30 15:59 ` Stefano Stabellini 2013-04-30 15:59 ` Stefano Stabellini 2013-04-30 12:38 ` [PATCH] ARM: add the "bool" type definition to asm/mach/arch.h Nicolas Ferre 2013-04-30 12:38 ` Nicolas Ferre 2013-04-30 14:05 ` Stefano Stabellini 2013-04-30 14:05 ` Stefano Stabellini
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.