From: Stefano Babic <sbabic@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/6] imx: mx35pdk: Convert to iomux-v3
Date: Tue, 30 Apr 2013 15:05:53 +0200 [thread overview]
Message-ID: <517FC1B1.2040106@denx.de> (raw)
In-Reply-To: <1110859211.411663.1367267988706.JavaMail.root@advansee.com>
On 29/04/2013 22:39, Beno?t Th?baudeau wrote:
> Hi Stefano,
>
Hi Beno?t,
> On Monday, April 29, 2013 10:41:18 PM, Beno?t Th?baudeau wrote:
>> There is no change of behavior.
>>
>> Signed-off-by: Beno?t Th?baudeau <benoit.thebaudeau@advansee.com>
>> ---
> [...]
>> diff --git a/board/freescale/mx35pdk/mx35pdk.c
>> b/board/freescale/mx35pdk/mx35pdk.c
>> index 9993d7b..12e84d7 100644
>> --- a/board/freescale/mx35pdk/mx35pdk.c
>> +++ b/board/freescale/mx35pdk/mx35pdk.c
> [...]
>> @@ -271,8 +243,7 @@ int board_late_init(void)
>> pmic_reg_read(p, REG_MODE_0, &pmic_val);
>> pmic_reg_write(p, REG_MODE_0, pmic_val | VGEN3EN);
>>
>> - mxc_request_iomux(MX35_PIN_COMPARE, MUX_CONFIG_GPIO);
>> - mxc_iomux_set_input(MUX_IN_GPIO1_IN_5, INPUT_CTL_PATH0);
>> + imx_iomux_v3_setup_pad(MX35_PAD_COMPARE__GPIO1_5);
>>
>> gpio_direction_output(IMX_GPIO_NR(2, 5), 1);
> ^
> Note that GPIO2[5] seems to be used instead of GPIO1[5] above. I have not
> checked if this is a bug or not. I let you check that as the board maintainer.
Good catch, in fact it is a bug ! According to schematics, GPIO1[5]
should be set to 1 (it drives a multiplexer), and not GPIO2[5]. I will
fix it later with another patch after yours flow into mainline.
Thanks,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
next prev parent reply other threads:[~2013-04-30 13:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 20:41 [U-Boot] [PATCH 1/6] imx: iomux-v3: Add iomux-mx35.h Benoît Thébaudeau
2013-04-29 20:41 ` [U-Boot] [PATCH 2/6] imx: flea3: Convert to iomux-v3 Benoît Thébaudeau
2013-04-29 20:41 ` [U-Boot] [PATCH 3/6] imx: mx35pdk: Fix WDOG_RST iomux function Benoît Thébaudeau
2013-04-29 20:41 ` [U-Boot] [PATCH 4/6] imx: mx35pdk: Convert to iomux-v3 Benoît Thébaudeau
2013-04-29 20:39 ` Benoît Thébaudeau
2013-04-30 13:05 ` Stefano Babic [this message]
2013-04-29 20:41 ` [U-Boot] [PATCH 5/6] imx: woodburn: " Benoît Thébaudeau
2013-04-29 20:41 ` [U-Boot] [PATCH 6/6] imx: mx35: Remove legacy iomux support Benoît Thébaudeau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=517FC1B1.2040106@denx.de \
--to=sbabic@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.