From mboxrd@z Thu Jan  1 00:00:00 1970
From: Julien Grall <julien.grall@linaro.org>
Subject: Re: [RFC 18/29] xen/arm: add generic UART to get the
 device in the device tree
Date: Tue, 30 Apr 2013 14:37:57 +0100
Message-ID: <517FC935.2010601@linaro.org>
References: <cover.1367188423.git.julien.grall@linaro.org>
	<b6b9bae716f1a337192d13ba985dedde97225456.1367188423.git.julien.grall@linaro.org>
	<1367250707.3142.360.camel@zakaz.uk.xensource.com>
	<517EACD3.6060107@linaro.org>
	<1367312968.3142.436.camel@zakaz.uk.xensource.com>
	<CAPnVf8zfXe7nampNHbCrgevF=ncq2jJO_0FeANzx6AV6iFcCyg@mail.gmail.com>
	<1367325684.3142.512.camel@zakaz.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1367325684.3142.512.camel@zakaz.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: Anthony Perard <anthony.perard@citrix.com>, "patches@linaro.org" <patches@linaro.org>, Stefano Stabellini <Stefano.Stabellini@eu.citrix.com>, "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 04/30/2013 01:41 PM, Ian Campbell wrote:

> 
> 
>>         Couldn't it also hardcode a call to a "is this a dt serial
>>         alias"
>>         function?
>>
>>
>> Indeed. Can we assume Xen on Arm will use only one UART? We can modify
>> the behaviour later.
> 
> This seems acceptable to me.
>>  
>>         > If I understand your suggestion, you suggest to use
>>         console=myserial
>>         > where *myserial* is the alias on the DTB, right?
>>         
>>         
>>         Right.
>>         
>>         > In this case the name could clash with the hardcoded ones in
>>         Xen that is not good.
>>         
>>         
>>         console=dt:<alias> ? Or to be honest I'm not sure that having
>>         the dt
>>         aliases shadow the Xen hardcoded ones would be a bad thing --
>>         the x86
>>         centric com<X> definition hardcoded in Xen is hardly likely to
>>         be useful
>>         on ARM or any DT using platform.
>>
>>
>> I prefer dt:<alias> but how do we parse the configuration for the
>> UART?
>>
>> Do we use dt:<alias>=configuration on the command line? In this case
>> I don't see function to retrieve a non-defined parameters on the
>> command line.
> 
> Hrm, yes.
> 
> Perhaps dtuart=, applied to whichever dt:<alias> you choose?
> 
>> We should also take care about video card. In the future, the devices
>> will be retrieved from the DTS.
> 
> In that case perhaps: console=dtuart:<alias> and =dtfb:<alias>?


Sounds good for me. I will rework the patch with that.

-- 
Julien