From mboxrd@z Thu Jan 1 00:00:00 1970 From: Julien Grall Subject: Re: [RFC 24/29] xen/arm: Don't use pl011 UART by default for early printk Date: Tue, 30 Apr 2013 14:57:28 +0100 Message-ID: <517FCDC8.9020908@linaro.org> References: <29c9b83854141ee04ee872e7477b8963e538be54.1367188423.git.julien.grall@linaro.org> <1367253944.3142.387.camel@zakaz.uk.xensource.com> <517EB7FA.9030404@linaro.org> <1367313528.3142.445.camel@zakaz.uk.xensource.com> <1367325888.3142.515.camel@zakaz.uk.xensource.com> <517FC999.3010407@linaro.org> <1367329895.3142.525.camel@zakaz.uk.xensource.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1367329895.3142.525.camel@zakaz.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell Cc: Anthony Perard , "patches@linaro.org" , Stefano Stabellini , "xen-devel@lists.xen.org" List-Id: xen-devel@lists.xenproject.org On 04/30/2013 02:51 PM, Ian Campbell wrote: > On Tue, 2013-04-30 at 14:39 +0100, Julien Grall wrote: >> On 04/30/2013 01:44 PM, Ian Campbell wrote: >> >>> On Tue, 2013-04-30 at 12:21 +0100, Julien Grall wrote: >>>> Missing Xen devel mailing list. >>> >>> Ignore my private reply, I've inserted it below... >>> >>>> >>>> Thanks. Even if we gate CONFIG_EARLY_PRINTK to debug=y, we >>>> should let the developper the option to disable/enable early >>>> printk. Otherwise we will lost debug when Xen can boot on >>>> multiple board. >>> >>> I'm not sure I follow, these are both valid >>> debug=y CONFIG_EARLY_PRINTK=pl011 >>> debug=y /* No early printk */ >>> In the latter case you have debug on a system which can boot on multiple >>> boards. >>> >>> Or are you concerned about not being able to build a production >>> (non-debug) hypervisor with early-printk? i.e. >>> debug=n CONFIG_EARLY_PRINTK=pl011 >>> ? >> >> It's the first one. CONFIG_EARLY_PRINTK should not be enabled on a >> production build. > > I'm still confused what your concern is. > > A build with debug=y is not a production build. I was not sure whether debug=y should imply CONFIG_EARLY_PRINTK or not. Sorry for the misreading. -- Julien