From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:34893)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UXBNz-00011B-44
	for qemu-devel@nongnu.org; Tue, 30 Apr 2013 10:18:28 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UXBNr-0008Et-9X
	for qemu-devel@nongnu.org; Tue, 30 Apr 2013 10:18:27 -0400
Received: from mx1.redhat.com ([209.132.183.28]:44487)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1UXBNr-0008Ee-1x
	for qemu-devel@nongnu.org; Tue, 30 Apr 2013 10:18:19 -0400
Message-ID: <517FD295.6000405@redhat.com>
Date: Tue, 30 Apr 2013 16:17:57 +0200
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1367248365-27260-1-git-send-email-fred.konrad@greensocs.com>
	<1367248365-27260-5-git-send-email-fred.konrad@greensocs.com>
	<517E9552.5020303@redhat.com> <517FC1BA.5070804@greensocs.com>
	<517FCEAF.5090107@redhat.com> <517FD1ED.50203@greensocs.com>
In-Reply-To: <517FD1ED.50203@greensocs.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH for-1.5 4/4] virtio-scsi: fix the command
 line compatibility.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-15?Q?KONRAD_Fr=E9d=E9ric?= <fred.konrad@greensocs.com>
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, agraf@suse.de, cornelia.huck@de.ibm.com, amit.shah@redhat.com, afaerber@suse.de

Il 30/04/2013 16:15, KONRAD Fr=E9d=E9ric ha scritto:
> On 30/04/2013 16:01, Paolo Bonzini wrote:
>> Il 30/04/2013 15:06, KONRAD Fr=E9d=E9ric ha scritto:
>>>> Could this be simply a qdev property?
>>> Well, maybe my solution is too extreme.
>>>
>>> Maybe I can put bus_name in struct VirtIODevice instead to avoid the
>>> set_virtio_x_bus_name code duplication?
>> No, I think it should be either DeviceState or single devices.
>>
>> Paolo
>>
> oops, just sent the fix with bus_name in VirtIODevice..
>=20
> I think it's not necessary to put bus_name in DeviceState as it is only
> needed for these two devices.
>=20
> But it may be better for it to be in VirtIODevice no?

Yeah, in the end it doesn't look bad... I should let other people who
followed the refactoring more closely decide.

Paolo