From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51552) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXCPe-0007Cw-0t for qemu-devel@nongnu.org; Tue, 30 Apr 2013 11:24:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXCPY-0005DY-KT for qemu-devel@nongnu.org; Tue, 30 Apr 2013 11:24:13 -0400 Message-ID: <517FE217.5000105@suse.de> Date: Tue, 30 Apr 2013 17:24:07 +0200 From: Alexander Graf MIME-Version: 1.0 References: <517D2B5B.1020806@web.de> <1367334424-10656-1-git-send-email-chouteau@adacore.com> In-Reply-To: <1367334424-10656-1-git-send-email-chouteau@adacore.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] Fix PReP NIP reset value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fabien Chouteau Cc: qemu-devel@nongnu.org, blauwirbel@gmail.com, andreas.faerber@web.de, qemu-ppc@nongnu.org, anthony@codemonkey.ws, aurelien@aurel32.net On 04/30/2013 05:07 PM, Fabien Chouteau wrote: > The value was changed by the "PPC: fix hreset_vector..." patch. > > Signed-off-by: Fabien Chouteau > --- > hw/ppc/prep.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c > index cceab3e..2d0c4fe 100644 > --- a/hw/ppc/prep.c > +++ b/hw/ppc/prep.c > @@ -427,6 +427,9 @@ static void ppc_prep_reset(void *opaque) > PowerPCCPU *cpu = opaque; > > cpu_reset(CPU(cpu)); > + > + /* Reset address */ > + cpu->env.nip = 0xfffffffc; Why does PREP reset at this vector? Is it architected to that? Does 601 reset to that offset? As an interim fix, I think this patch is ok however. Alex > } > > /* PowerPC PREP hardware initialisation */