Re: [Qemu-devel] [PATCH 6/7] block: move qmp and info dump related code to block/qapi.c

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]

On 04/26/2013 03:31 AM, Wenchao Xia wrote:
> This patch is a pure code move patch, except following modification:
> 1 get_human_readable_size() is changed to static function.
> 2 dump_human_image_info() is renamed to bdrv_image_info_dump().
> 3 in qmp_query_block() and qmp_query_blockstats, use bdrv_next(bs)
> instead of direct traverse of global array 'bdrv_states'.
> 4 code style fix.
> 
> Now block.h and snapshot.h are at the same level in include path,
> block_int.h and qapi.h will both include them.
> 
> Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
> ---
>  block.c                   |  185 ---------------------------------
>  block/qapi.c              |  253 +++++++++++++++++++++++++++++++++++++++++++++
>  include/block/block.h     |   10 --
>  include/block/block_int.h |    1 +
>  include/block/qapi.h      |    6 +
>  qemu-img.c                |   69 +------------
>  savevm.c                  |    1 +
>  7 files changed, 262 insertions(+), 263 deletions(-)

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 621 bytes --]