From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44558) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXGeE-0004GM-9x for qemu-devel@nongnu.org; Tue, 30 Apr 2013 15:55:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXGe9-0004WD-AB for qemu-devel@nongnu.org; Tue, 30 Apr 2013 15:55:34 -0400 Message-ID: <518021A2.1090401@reactos.org> Date: Tue, 30 Apr 2013 21:55:14 +0200 From: =?ISO-8859-1?Q?Herv=E9_Poussineau?= MIME-Version: 1.0 References: <517D2B5B.1020806@web.de> <1367334424-10656-1-git-send-email-chouteau@adacore.com> <517FE217.5000105@suse.de> <517FEA86.3040507@adacore.com> <517FEC00.7070506@suse.de> <517FF00A.5040207@adacore.com> <517FF31E.3000002@suse.de> In-Reply-To: <517FF31E.3000002@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] Fix PReP NIP reset value List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org, Fabien Chouteau , blauwirbel@gmail.com, andreas.faerber@web.de, qemu-ppc@nongnu.org, anthony@codemonkey.ws, aurelien@aurel32.net Alexander Graf a =E9crit : > On 04/30/2013 06:23 PM, Fabien Chouteau wrote: >> On 04/30/2013 06:06 PM, Alexander Graf wrote: >>> On 04/30/2013 06:00 PM, Fabien Chouteau wrote: >>>> On 04/30/2013 05:24 PM, Alexander Graf wrote: >>>>> On 04/30/2013 05:07 PM, Fabien Chouteau wrote: >>>>>> The value was changed by the "PPC: fix hreset_vector..." patch. >>>>>> >>>>>> Signed-off-by: Fabien Chouteau >>>>>> --- >>>>>> hw/ppc/prep.c | 3 +++ >>>>>> 1 file changed, 3 insertions(+) >>>>>> >>>>>> diff --git a/hw/ppc/prep.c b/hw/ppc/prep.c >>>>>> index cceab3e..2d0c4fe 100644 >>>>>> --- a/hw/ppc/prep.c >>>>>> +++ b/hw/ppc/prep.c >>>>>> @@ -427,6 +427,9 @@ static void ppc_prep_reset(void *opaque) >>>>>> PowerPCCPU *cpu =3D opaque; >>>>>> >>>>>> cpu_reset(CPU(cpu)); >>>>>> + >>>>>> + /* Reset address */ >>>>>> + cpu->env.nip =3D 0xfffffffc; >>>>> Why does PREP reset at this vector? Is it architected to that? Does= =20 >>>>> 601 reset to that offset? >>>>> >>>> I don't know why PReP reset here. As I said in the hreset_vector pat= ch, >>>> even if the core manual says that hreset is at 0xfff00100, the value= is >>>> in fact board specific. OpenHackWare expects 0xfffffffc as reset >>>> address. >>> Do you have 601e or 601 specs handy? Maybe they have a different=20 >>> reset vector. >>> >> None of the specs I have talk about 0xfffffffc... >> >>> Maybe OHW is also just wrong ;). >>> >> Maybe, but I have no way to prove it. >=20 > Ok, let's leave it at that patch then ;). It'd be good to know if herve= =20 > can boot his real images from 0x100. If so, OHW is likely at fault and=20 > we can revert the change once Andreas switched to OpenBIOS. My real image only booted with a 601 and 604 which had a reset vector of=20 0x00000100. With the committed change, 602 and 603 also work. So I think that the change is correct, and that OpenHackWare incorrectly=20 assumes a reset vector of 0xfffffffc... Herv=E9