All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Elder <elder@inktank.com>
To: Josh Durgin <josh.durgin@inktank.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH 0/4] rbd: get rid of the snapshot list
Date: Tue, 30 Apr 2013 20:16:37 -0500	[thread overview]
Message-ID: <51806CF5.2080703@inktank.com> (raw)
In-Reply-To: <51806C07.60007@inktank.com>

On 04/30/2013 08:12 PM, Alex Elder wrote:
> On that, the only thing inefficient is looking up the
> snapshot id given its name.  It is so inefficient it
> might be worth offering an op that does that for us,
> because as it is we have to do a sequential search
> to find out a snapshot's name.  (Maybe it's not that
> important to track the name for parent snapshots but
> users might be interested.)

Looking at this, I was confused as I wrote it...

For a v2 snapshot, we iterate across snapshot ids in
the context, and fetch the name for each.  Only
when we find the name that matches the one sought
do we know which id it's associated with.

Anyway, once we know the id it's a direct query
for all the other info.

					-Alex

  reply	other threads:[~2013-05-01  1:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-30 12:41 [PATCH 0/4] rbd: get rid of the snapshot list Alex Elder
2013-04-30 12:42 ` [PATCH 1/4] rbd: look up snapshot name in names buffer Alex Elder
2013-04-30 12:42 ` [PATCH 2/4] rbd: use snap_id not index to look up snap info Alex Elder
2013-04-30 12:42 ` [PATCH 3/4] rbd: define rbd_snap_size() and rbd_snap_features() Alex Elder
2013-04-30 12:43 ` [PATCH 4/4] rbd: kill off the snapshot list Alex Elder
2013-05-01  0:57 ` [PATCH 0/4] rbd: get rid of " Josh Durgin
2013-05-01  1:12   ` Alex Elder
2013-05-01  1:16     ` Alex Elder [this message]
2013-05-01  1:32     ` Josh Durgin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51806CF5.2080703@inktank.com \
    --to=elder@inktank.com \
    --cc=ceph-devel@vger.kernel.org \
    --cc=josh.durgin@inktank.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.