From: Alex Elder <elder@inktank.com>
To: Josh Durgin <josh.durgin@inktank.com>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH 3/5] rbd: define rbd_dev_unprobe()
Date: Tue, 30 Apr 2013 23:57:23 -0500 [thread overview]
Message-ID: <5180A0B3.6030401@inktank.com> (raw)
In-Reply-To: <51806BB4.2060901@inktank.com>
On 04/30/2013 08:11 PM, Josh Durgin wrote:
> There are a couple calls that look unnecessary noted below.
You were correct, in the two places that you mentioned,
rbd_parent_remove() should go away. I'll do that before
I commit.
-Alex
> Other than that:
>
> Reviewed-by: Josh Durgin <josh.durgin@inktank.com>
next prev parent reply other threads:[~2013-05-01 4:57 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 17:59 [PATCH 0/5] rbd: only set up Linux files for mapped devices Alex Elder
2013-04-29 18:00 ` [PATCH 1/5] rbd: drop module later Alex Elder
2013-04-29 18:00 ` [PATCH 2/5] rbd: don't destroy rbd_dev in device release function Alex Elder
2013-04-29 18:00 ` [PATCH 3/5] rbd: define rbd_dev_unprobe() Alex Elder
2013-05-01 1:11 ` Josh Durgin
2013-05-01 4:57 ` Alex Elder [this message]
2013-04-29 18:00 ` [PATCH 4/5] rbd: don't have device release destroy rbd_dev Alex Elder
2013-04-29 18:01 ` [PATCH 5/5] rbd: set up devices only for mapped images Alex Elder
2013-05-01 1:15 ` [PATCH 0/5] rbd: only set up Linux files for mapped devices Josh Durgin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5180A0B3.6030401@inktank.com \
--to=elder@inktank.com \
--cc=ceph-devel@vger.kernel.org \
--cc=josh.durgin@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.