All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Dingwall <james.dingwall@zynstra.com>
To: xfs@oss.sgi.com
Subject: Cleancache support in XFS
Date: Wed, 1 May 2013 13:39:09 +0100	[thread overview]
Message-ID: <51810CED.4080003@zynstra.com> (raw)

In reference to: http://oss.sgi.com/archives/xfs/2012-05/msg00046.html

$ grep -r cleancache fs/xfs
on the 3.9 kernel source suggests that no patch was submitted to enable 
cleancache for the XFS filesystem.  Since it was suggested that this 
could be a one liner I've had a go and my first effort is inline below.  
While this seems to compile OK I have no experience in filesystems so I 
would appreciate it if anyone can point out that it is obviously wrong 
and likely to eat my data before I try booting the kernel.

If it seems a reasonable attempt what would be the best way to check 
that it isn't doing nasty things?

Thanks,
James

--- xfs_super.c 2013-04-29 10:28:22.000000000 +0100
+++ xfs_super.cleancache.c      2013-05-01 13:22:44.367763564 +0100
@@ -61,6 +61,7 @@
  #include <linux/kthread.h>
  #include <linux/freezer.h>
  #include <linux/parser.h>
+#include <linux/cleancache.h>

  static const struct super_operations xfs_super_operations;
  static kmem_zone_t *xfs_ioend_zone;
@@ -1489,6 +1490,8 @@
                 goto out_unmount;
         }

+       cleancache_init_fs(sb);
+
         return 0;

   out_filestream_unmount:

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

             reply	other threads:[~2013-05-01 12:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-01 12:39 James Dingwall [this message]
2013-05-01 16:20 ` Cleancache support in XFS Ben Myers
2013-05-01 22:30   ` Dave Chinner
2013-05-02  8:24     ` James Dingwall
2013-05-22 19:28       ` Konrad Rzeszutek Wilk
2013-05-24  7:30         ` James Dingwall
2013-06-07 17:08           ` Konrad Rzeszutek Wilk
2013-07-19  7:18             ` James Dingwall
2013-07-22 15:48               ` Konrad Rzeszutek Wilk
2013-07-23  7:23                 ` James Dingwall
2013-07-23  8:27                   ` Dave Chinner
2013-07-23  8:53                     ` James Dingwall
2013-11-21 13:35                     ` James Dingwall
2013-11-21 16:07                       ` Ben Myers
2013-11-21 22:12                         ` Dave Chinner
2013-11-26 16:35                           ` Konrad Rzeszutek Wilk
2013-11-26 16:35                         ` Konrad Rzeszutek Wilk
2013-05-13  8:59 ` James Dingwall
  -- strict thread matches above, loose matches on Subject: below --
2012-04-30 17:31 Alexey Vlasov
2012-04-30 19:12 ` Christoph Hellwig
2012-05-02  8:02   ` Alexey Vlasov
2012-05-05 23:40     ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51810CED.4080003@zynstra.com \
    --to=james.dingwall@zynstra.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.