From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Alexander Duyck <alexander.h.duyck@intel.com>
Cc: shemminger@vyatta.com, netdev@vger.kernel.org,
jeffrey.t.kirsher@intel.com, Hasan Chowdhury <shemonc@gmail.com>,
Pablo Neira Ayuso <pablo@netfilter.org>
Subject: Re: [IPROUTE PATCH v2] iproute2: act_ipt fix xtables breakage on older versions.
Date: Wed, 01 May 2013 09:47:50 -0400 [thread overview]
Message-ID: <51811D06.2070800@mojatatu.com> (raw)
In-Reply-To: <517FEC48.80700@intel.com>
Hi Alex,
On 13-04-30 12:07 PM, Alexander Duyck wrote:
> On 04/30/2013 05:59 AM, Jamal Hadi Salim wrote:
>
> In the git tree it is obvious that xtables_merge_options only takes 3
> parameters. It is not until v1.4.11 which is XTABLES_VERSION_CODE == 6
> that we see xtables_merge_options take 4 parameters.
>
I apologize, you are correct. So whats incorporated now is wrong
but compiles fine on Debian.
So now i am wondering how the FSCK this thing even compiled.
I am going to test your patch on Debian squeeze, with iptables 1.4.8
(where the current code compiles just fine) and will ack it if all is
good
cheers,
jamal
next prev parent reply other threads:[~2013-05-01 13:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 15:50 [IPROUTE PATCH v2] iproute2: act_ipt fix xtables breakage on older versions Alexander Duyck
2013-04-30 12:59 ` Jamal Hadi Salim
2013-04-30 16:07 ` Alexander Duyck
2013-05-01 13:47 ` Jamal Hadi Salim [this message]
2013-05-01 14:21 ` Jamal Hadi Salim
2013-05-01 17:18 ` Alexander Duyck
2013-05-01 14:22 ` Jamal Hadi Salim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51811D06.2070800@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=alexander.h.duyck@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=shemminger@vyatta.com \
--cc=shemonc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.