All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: "Shankar, Uma" <uma.shankar@intel.com>,
	"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>
Subject: RE: [PATCH 1/3] drm/xe/display: drop redundant intel_hpd_poll_fini() call
Date: Wed, 05 Aug 2026 10:25:38 +0300	[thread overview]
Message-ID: <518135db2b7bc413acf620620f40fdccde1b7817@intel.com> (raw)
In-Reply-To: <DM4PR11MB6360EDF0058411C6CE544818F4D42@DM4PR11MB6360.namprd11.prod.outlook.com>

On Tue, 04 Aug 2026, "Shankar, Uma" <uma.shankar@intel.com> wrote:
>> -----Original Message-----
>> From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf Of Jani Nikula
>> Sent: Tuesday, July 28, 2026 8:20 PM
>> To: intel-xe@lists.freedesktop.org
>> Cc: Nikula, Jani <jani.nikula@intel.com>
>> Subject: [PATCH 1/3] drm/xe/display: drop redundant intel_hpd_poll_fini() call
>> 
>> intel_hpd_poll_fini() is already being called via
>> xe_display_fini_early() -> intel_display_driver_remove_noirq(). Remove the
>> redundant call.
>
> Looks Good to me.
> Reviewed-by: Uma Shankar <uma.shankar@intel.com>

Thanks for the reviews, series pushed to din.

BR,
Jani.

>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>>  drivers/gpu/drm/xe/display/xe_display.c | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/xe/display/xe_display.c
>> b/drivers/gpu/drm/xe/display/xe_display.c
>> index 8da4c457a4a0..57088e24aba2 100644
>> --- a/drivers/gpu/drm/xe/display/xe_display.c
>> +++ b/drivers/gpu/drm/xe/display/xe_display.c
>> @@ -129,7 +129,6 @@ static void xe_display_fini(void *arg)
>>  	struct xe_device *xe = arg;
>>  	struct intel_display *display = xe->display;
>> 
>> -	intel_hpd_poll_fini(display);
>>  	intel_hdcp_component_fini(display);
>>  	intel_audio_deinit(display);
>>  	intel_display_driver_remove(display);
>> --
>> 2.47.3
>

-- 
Jani Nikula, Intel

  reply	other threads:[~2026-08-05  7:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-28 14:50 [PATCH 0/3] drm/xe/display: remove some redundant cleanup calls Jani Nikula
2026-07-28 14:50 ` [PATCH 1/3] drm/xe/display: drop redundant intel_hpd_poll_fini() call Jani Nikula
2026-08-04 15:16   ` Shankar, Uma
2026-08-05  7:25     ` Jani Nikula [this message]
2026-07-28 14:50 ` [PATCH 2/3] drm/xe/display: drop redundant intel_hdcp_component_fini() call Jani Nikula
2026-08-04 15:17   ` Shankar, Uma
2026-07-28 14:50 ` [PATCH 3/3] drm/xe/display: drop redundant intel_audio_deinit() call Jani Nikula
2026-08-04 15:18   ` Shankar, Uma
2026-07-28 15:30 ` ✓ CI.KUnit: success for drm/xe/display: remove some redundant cleanup calls Patchwork
2026-07-28 16:11 ` ✓ Xe.CI.BAT: " Patchwork
2026-07-28 19:24 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=518135db2b7bc413acf620620f40fdccde1b7817@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=uma.shankar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.