From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1UXaqh-0007ge-UD for mharc-qemu-trivial@gnu.org; Wed, 01 May 2013 13:29:47 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXaqf-0007dN-C3 for qemu-trivial@nongnu.org; Wed, 01 May 2013 13:29:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXaqe-0000mc-Al for qemu-trivial@nongnu.org; Wed, 01 May 2013 13:29:45 -0400 Received: from cantor2.suse.de ([195.135.220.15]:35891 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXaqY-0000hW-4r; Wed, 01 May 2013 13:29:38 -0400 Received: from relay1.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 5384AA50DE; Wed, 1 May 2013 19:29:37 +0200 (CEST) Message-ID: <518150FE.1000501@suse.de> Date: Wed, 01 May 2013 19:29:34 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= Organization: SUSE LINUX Products GmbH User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Michael Tokarev References: <1367290790-19159-1-git-send-email-lig.fnst@cn.fujitsu.com> <51814C37.4060000@msgid.tls.msk.ru> In-Reply-To: <51814C37.4060000@msgid.tls.msk.ru> X-Enigmail-Version: 1.6a1pre Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x X-Received-From: 195.135.220.15 Cc: qemu-trivial@nongnu.org, Peter Maydell , qemu-devel , liguang Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h X-BeenThere: qemu-trivial@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 May 2013 17:29:46 -0000 Am 01.05.2013 19:09, schrieb Michael Tokarev: > 30.04.2013 06:59, liguang wrote: >> Signed-off-by: liguang >> --- >> translate-all.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >=20 > Hmm. Does we require S-o-b line even for such a trivial (but neverthel= ess important) stuff? Yes: http://wiki.qemu.org/Contribute/SubmitAPatch If it's missing, author can either reply with Signed-off-by - if you're willing to fix it up - or resend. And whenever you pick up patches, you sign them off as well. > Also, Peter, does your followup email mean your Rewieved-by should be a= dded too? No, generally not if it was not explicitly given. Exception from the rule: We have allowed to turn an informal "ack" into an Acked-by. Thanks for taking over qemu-trivial! Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:33751) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXaqb-0007d3-RF for qemu-devel@nongnu.org; Wed, 01 May 2013 13:29:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXaqY-0000he-B7 for qemu-devel@nongnu.org; Wed, 01 May 2013 13:29:41 -0400 Message-ID: <518150FE.1000501@suse.de> Date: Wed, 01 May 2013 19:29:34 +0200 From: =?ISO-8859-1?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1367290790-19159-1-git-send-email-lig.fnst@cn.fujitsu.com> <51814C37.4060000@msgid.tls.msk.ru> In-Reply-To: <51814C37.4060000@msgid.tls.msk.ru> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] translate: remove redundantly included qemu/timer.h List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Michael Tokarev Cc: qemu-trivial@nongnu.org, Peter Maydell , qemu-devel , liguang Am 01.05.2013 19:09, schrieb Michael Tokarev: > 30.04.2013 06:59, liguang wrote: >> Signed-off-by: liguang >> --- >> translate-all.c | 1 - >> 1 files changed, 0 insertions(+), 1 deletions(-) >=20 > Hmm. Does we require S-o-b line even for such a trivial (but neverthel= ess important) stuff? Yes: http://wiki.qemu.org/Contribute/SubmitAPatch If it's missing, author can either reply with Signed-off-by - if you're willing to fix it up - or resend. And whenever you pick up patches, you sign them off as well. > Also, Peter, does your followup email mean your Rewieved-by should be a= dded too? No, generally not if it was not explicitly given. Exception from the rule: We have allowed to turn an informal "ack" into an Acked-by. Thanks for taking over qemu-trivial! Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg