From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50231) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXfu6-0003uP-RO for qemu-devel@nongnu.org; Wed, 01 May 2013 18:53:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXfu5-0006vj-Aa for qemu-devel@nongnu.org; Wed, 01 May 2013 18:53:38 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46198 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXfu5-0006vb-0x for qemu-devel@nongnu.org; Wed, 01 May 2013 18:53:37 -0400 Message-ID: <51819CED.5070300@suse.de> Date: Thu, 02 May 2013 00:53:33 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1366657220-776-1-git-send-email-ehabkost@redhat.com> In-Reply-To: <1366657220-776-1-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu 0/9] x86: feature words array (v11) + "feature-words" property List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: libvir-list@redhat.com, Markus Armbruster , qemu-devel@nongnu.org, Luiz Capitulino , Anthony Liguori , Igor Mammedov , Jiri Denemark Am 22.04.2013 21:00, schrieb Eduardo Habkost: > This series includes the previous "replace cpuid_*features fields with = a feature > word array" series. >=20 > The first 4 patches already have a Reviewed-by from Igor, they correspo= nd to v10 > plus a small indent fix requested by him. >=20 > As the cpuid_*features series was holding my "feature-words"/"filtered-= features" > series (previously sent as RFC), I am now sending both as a single seri= es, to > try to get "feature-words"/"filtered-features" some attention and try t= o get it > included in 1.5. >=20 > The "feature-words"/"filtered-features" mechanism is very important for= libvirt, > to allow it to ensure the guest is getting the required set of CPU feat= ures, as > configured by the user. >=20 >=20 > Eduardo Habkost (9): > target-i386: cleanup: Group together level, xlevel, xlevel2 fields > target-i386/kvm.c: Code formatting changes > target-i386/cpu.c: Break lines so they don't get too long > target-i386: Replace cpuid_*features fields with a feature word array Thanks, applied these to qom-cpu: https://github.com/afaerber/qemu-cpu/commits/qom-cpu These had been around for quite some time and I have reviewed the first three line by line; for the fourth I have looked at the script sources and trust Igor's review. Thanks for repeatedly rebasing this, Eduardo! > target-i386: Add ECX information to FeatureWordInfo This one is lacking Reviewed-by / Acked-by ... > target-i386: Add "feature-words" property > target-i386: Use FeatureWord loop on filter_features_for_kvm() ... and this one seems to depend on it. > target-i386: Introduce X86CPU.filtered_features field > target-i386: Add "filtered-features" property to X86CPU As mentioned earlier I'd prefer to defer the property design rather than putting it lightly reviewed into 1.5 and living with some ABI. If libvirt urgently needs this info, this series needs to be reviewed and sorted out until the weekend (Hard Freeze on Monday). Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg