From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50447) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXfwC-0004xq-0Z for qemu-devel@nongnu.org; Wed, 01 May 2013 18:55:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UXfwA-0007g8-JW for qemu-devel@nongnu.org; Wed, 01 May 2013 18:55:47 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46242 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UXfwA-0007g4-Ct for qemu-devel@nongnu.org; Wed, 01 May 2013 18:55:46 -0400 Message-ID: <51819D70.7090707@suse.de> Date: Thu, 02 May 2013 00:55:44 +0200 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1366657220-776-1-git-send-email-ehabkost@redhat.com> <1366657220-776-3-git-send-email-ehabkost@redhat.com> In-Reply-To: <1366657220-776-3-git-send-email-ehabkost@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-cpu 2/9] target-i386/kvm.c: Code formatting changes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: libvir-list@redhat.com, Igor Mammedov , Jiri Denemark , qemu-devel@nongnu.org Am 22.04.2013 21:00, schrieb Eduardo Habkost: > Add appropriate spaces around operators, and break line where it needs > to be broken to allow feature-words array to be introduced without > having too-long lines. >=20 > Signed-off-by: Eduardo Habkost > Reviewed-By: Igor Mammedov > --- > Changes v9: > * 1-char alignment change: keep the opening parenthesis of both sides > of the "=3D=3D" operator starting at the same column > --- > target-i386/kvm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/target-i386/kvm.c b/target-i386/kvm.c > index 0e7cc81..b5bff33 100644 > --- a/target-i386/kvm.c > +++ b/target-i386/kvm.c > @@ -613,7 +613,8 @@ int kvm_arch_init_vcpu(CPUState *cs) > cpuid_data.cpuid.nent =3D cpuid_i; > =20 > if (((env->cpuid_version >> 8)&0xF) >=3D 6 > - && (env->cpuid_features&(CPUID_MCE|CPUID_MCA)) =3D=3D (CPUID_M= CE|CPUID_MCA) > + && (env->cpuid_features & (CPUID_MCE|CPUID_MCA)) =3D=3D > + (CPUID_MCE|CPUID_MCA) I've added spaces around the | operator as well. :) Andreas > && kvm_check_extension(cs->kvm_state, KVM_CAP_MCE) > 0) { > uint64_t mcg_cap; > int banks; >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg