From: Randy MacLeod <randy.macleod@windriver.com>
To: Khem Raj <raj.khem@gmail.com>
Cc: yocto@yoctoproject.org
Subject: Re: [PATCH] libsemanage: drop flag: -Wno-unused-but-set-variable
Date: Wed, 1 May 2013 19:02:37 -0400 [thread overview]
Message-ID: <51819F0D.4020607@windriver.com> (raw)
In-Reply-To: <DAF195EB-C48B-48DC-A9C5-42A2D4D9F214@gmail.com>
On 13-05-01 12:12 AM, Khem Raj wrote:
>
> On Apr 30, 2013, at 8:15 PM, Randy MacLeod <randy.macleod@windriver.com> wrote:
>
>> The flag: -Wno-unused-but-set-variable isn't supported on older
>> versions of gcc such as gcc-4.1.2 which is the native compiler for
>> RHEL-5.9. Drop this warning flag for both the native and target builds.
>
>
> why drop from target build ?
I thought I'd have to create a separate -native recipe and
that didn't seem to be worthwhile for this warning flag.
On the other hand, the recipe is tiny so I could fix it up
if you think it's important. Oh and I should fix the _git
version of libselinux too.
// Randy
>
>>
>> Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
>> ---
>> ...semanage-drop-Wno-unused-but-set-variable.patch | 17 +++++++++++++++++
>> recipes-security/selinux/libsemanage_2.1.9.bb | 6 ++++--
>> recipes-security/selinux/libsemanage_git.bb | 6 ++++--
>> 3 files changed, 25 insertions(+), 4 deletions(-)
>> create mode 100644 recipes-security/selinux/libsemanage/libsemanage-drop-Wno-unused-but-set-variable.patch
>>
>> diff --git a/recipes-security/selinux/libsemanage/libsemanage-drop-Wno-unused-but-set-variable.patch b/recipes-security/selinux/libsemanage/libsemanage-drop-Wno-unused-but-set-variable.patch
>> new file mode 100644
>> index 0000000..faf8fc5
>> --- /dev/null
>> +++ b/recipes-security/selinux/libsemanage/libsemanage-drop-Wno-unused-but-set-variable.patch
>> @@ -0,0 +1,17 @@
>> +Subject: libselinux: drop flag: -Wno-unused-but-set-variable
>> +
>> +Upstream status: inappropriate (older compilers only).
>> +
>> +Signed-off-by: Randy MacLeod <Randy.MacLeod@windriver.com>
>> +
>> +--- libsemanage-2.1.9.orig/src/Makefile
>> ++++ libsemanage-2.1.9/src/Makefile
>> +@@ -57,7 +57,7 @@
>> + LOBJS= $(patsubst %.c,%.lo,$(SRCS)) conf-scan.lo conf-parse.lo
>> + CFLAGS ?= -Werror -Wall -W -Wundef -Wshadow -Wmissing-noreturn -Wmissing-format-attribute
>> +
>> +-SWIG_CFLAGS += -Wno-error -Wno-unused-but-set-variable -Wno-unused-variable -Wno-shadow \
>> ++SWIG_CFLAGS += -Wno-error -Wno-unused-variable -Wno-shadow \
>> + -Wno-unused-parameter
>> +
>> + override CFLAGS += -I../include -I$(INCLUDEDIR) -D_GNU_SOURCE
>> diff --git a/recipes-security/selinux/libsemanage_2.1.9.bb b/recipes-security/selinux/libsemanage_2.1.9.bb
>> index 0e0bc41..3b1d8db 100644
>> --- a/recipes-security/selinux/libsemanage_2.1.9.bb
>> +++ b/recipes-security/selinux/libsemanage_2.1.9.bb
>> @@ -1,4 +1,4 @@
>> -PR = "r0"
>> +PR = "r1"
>>
>> include selinux_20120924.inc
>> include ${BPN}.inc
>> @@ -11,4 +11,6 @@ SRC_URI[sha256sum] = "6f01d17f9751412f7b76e6e7daafeb2faf301b9bfeea83506160c81bec
>> SRC_URI += "\
>> file://libsemanage-Fix-execve-segfaults-on-Ubuntu.patch \
>> file://libsemanage-fix-path-len-limit.patch \
>> - file://libsemanage-fix-path-nologin.patch"
>> + file://libsemanage-fix-path-nologin.patch \
>> + file://libsemanage-drop-Wno-unused-but-set-variable.patch \
>> + "
>> diff --git a/recipes-security/selinux/libsemanage_git.bb b/recipes-security/selinux/libsemanage_git.bb
>> index 562512c..b3819a0 100644
>> --- a/recipes-security/selinux/libsemanage_git.bb
>> +++ b/recipes-security/selinux/libsemanage_git.bb
>> @@ -1,4 +1,4 @@
>> -PR = "r4"
>> +PR = "r5"
>> PV = "2.1.6+git${SRCPV}"
>>
>> include selinux_git.inc
>> @@ -10,4 +10,6 @@ SRC_URI += "file://Fix-segfault-for-standard-policy.patch \
>> file://libsemanage-Fix-execve-segfaults-on-Ubuntu.patch \
>> file://libsemanage-semanage.conf-for-cross-compile.patch \
>> file://libsemanage-fix-path-len-limit.patch \
>> - file://libsemanage-fix-path-nologin.patch"
>> + file://libsemanage-fix-path-nologin.patch \
>> + file://libsemanage-drop-Wno-unused-but-set-variable.patch \
>> + "
>> --
>> 1.7.4.1
>>
>> _______________________________________________
>> yocto mailing list
>> yocto@yoctoproject.org
>> https://lists.yoctoproject.org/listinfo/yocto
>
--
# Randy MacLeod. SMTS, Linux, Wind River
Direct: 613.963.1350
next prev parent reply other threads:[~2013-05-01 23:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-01 3:15 [PATCH] libsemanage: drop flag: -Wno-unused-but-set-variable Randy MacLeod
2013-05-01 4:12 ` Khem Raj
2013-05-01 23:02 ` Randy MacLeod [this message]
2013-05-02 14:09 ` Mark Hatle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51819F0D.4020607@windriver.com \
--to=randy.macleod@windriver.com \
--cc=raj.khem@gmail.com \
--cc=yocto@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.