All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: David Mosberger-Tang <dmosberger@gmail.com>
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
	Brian Norris <computersforpeace@gmail.com>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	David Woodhouse <David.Woodhouse@intel.com>
Subject: Re: nand_base: fix for ONFI chips that do not support GET/SET FEATURES
Date: Thu, 2 May 2013 10:41:32 +0800	[thread overview]
Message-ID: <5181D25C.2080001@freescale.com> (raw)
In-Reply-To: <CACwUX0M_CGStWih0qcR_8na-yMmvHrAaHxpYe4Y_Q5mx+jno+g@mail.gmail.com>

于 2013年05月02日 10:34, David Mosberger-Tang 写道:
> +	    !(le16_to_cpu(chip->onfi_params.opt_cmd) & 4))
it's better to add a macro to replace the hardcore '4', such as

#define ONFI_OPT_CMD_SET_GET_FEAT (1 << 2)

Just a suggestion. :)

thanks
Huang Shijie

  reply	other threads:[~2013-05-02  2:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-30 23:39 nand_base: fix for ONFI chips that do not support GET/SET FEATURES David Mosberger-Tang
2013-05-02  2:28 ` Huang Shijie
2013-05-02  2:34   ` David Mosberger-Tang
2013-05-02  2:41     ` Huang Shijie [this message]
2013-05-02  3:45       ` David Mosberger-Tang
2013-05-02  3:49         ` David Mosberger-Tang
2013-05-29 12:31           ` Artem Bityutskiy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5181D25C.2080001@freescale.com \
    --to=b32955@freescale.com \
    --cc=David.Woodhouse@intel.com \
    --cc=artem.bityutskiy@linux.intel.com \
    --cc=computersforpeace@gmail.com \
    --cc=dmosberger@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.