All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 3/3] rootfs-overlay: use a make foreach instead of a shell for
Date: Thu, 02 May 2013 09:30:42 +0200	[thread overview]
Message-ID: <51821622.4080306@lucaceresoli.net> (raw)
In-Reply-To: <517FF854.9090903@mind.be>

Arnout Vandecappelle wrote:
> On 08/04/13 18:50, Luca Ceresoli wrote:
>> Makes the code uniform with the post-build and post-image implementation
>> (which is slightly simpler and, presumably, more efficient).
>>
>> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
>
> Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
>
>  I thought about the possibility to refactor these three use cases 
> into a single make function, but it would actually just complicate 
> things.

I considered this as well, but for so few lines it would be overkill.

Thanks for your review,
Luca

      parent reply	other threads:[~2013-05-02  7:30 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-08 16:50 [Buildroot] [PATCH v2 0/3] Cleanup post-* loops Luca Ceresoli
2013-04-08 16:50 ` [Buildroot] [PATCH v2 1/3] post-build: show each script filename before execution Luca Ceresoli
2013-04-16 21:49   ` Yann E. MORIN
2013-04-17 16:13   ` Arnout Vandecappelle
2013-04-18  7:14     ` Yann E. MORIN
2013-04-24 20:15   ` Peter Korsgaard
2013-04-26  7:25     ` Luca Ceresoli
2013-04-30 16:57   ` Arnout Vandecappelle
2013-04-30 20:31     ` Peter Korsgaard
2013-04-08 16:50 ` [Buildroot] [PATCH v2 2/3] post-image: " Luca Ceresoli
2013-04-16 21:50   ` Yann E. MORIN
2013-04-24 20:16   ` Peter Korsgaard
2013-04-30 16:58   ` Arnout Vandecappelle
2013-04-08 16:50 ` [Buildroot] [PATCH v2 3/3] rootfs-overlay: use a make foreach instead of a shell for Luca Ceresoli
2013-04-16 21:55   ` Yann E. MORIN
2013-04-30 16:59   ` Arnout Vandecappelle
2013-04-30 20:33     ` Peter Korsgaard
2013-05-02  7:30     ` Luca Ceresoli [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51821622.4080306@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.