From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michal Kazior Date: Thu, 2 May 2013 11:18:35 +0200 Subject: [ath9k-devel] [PATCH 2/2] ath10k: only warn about incompatible firmware versions In-Reply-To: <20130502090223.2932.24852.stgit@localhost6.localdomain6> References: <20130502090142.2932.3314.stgit@localhost6.localdomain6> <20130502090223.2932.24852.stgit@localhost6.localdomain6> Message-ID: <51822F6B.9070405@tieto.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: ath9k-devel@lists.ath9k.org On 02/05/13 11:02, Kalle Valo wrote: > Most of the time it does more harm than good to halt the > driver initialisation if the firmware version is not > supported. For example, sometimes it's good to test > something from older versions etc. So just change the > check to a warning. > > Signed-off-by: Kalle Valo > --- > drivers/net/wireless/ath/ath10k/core.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c > index a511aaf..475ca1a 100644 > --- a/drivers/net/wireless/ath/ath10k/core.c > +++ b/drivers/net/wireless/ath/ath10k/core.c > @@ -84,10 +84,11 @@ static int ath10k_check_fw_version(struct ath10k *ar) > SUPPORTED_FW_MAJOR, SUPPORTED_FW_MINOR, > SUPPORTED_FW_RELEASE, SUPPORTED_FW_BUILD); > > - ath10k_err("Firmware %s is not supported. Please use version %s (or newer)\n", > - ar->hw->wiphy->fw_version, version); > + ath10k_warn("WARNING: Firmware version %s is not officially supported.\n", > + ar->hw->wiphy->fw_version); > + ath10k_warn("Please upgrade to version %s (or newer)\n", version); > > - return -EINVAL; > + return 0; > } Perhaps we should also be taking the abi_version (from wmi_service_ready_event) into account. I'm not sure if FW really fills that one out though. The "or newer" doesn't seem to suit here either. If new FW has ABI changes we're screwed. -- Pozdrawiam / Best regards, Michal Kazior.