From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH v6 01/16] spi/spi-atmel: fix probing failure after xfer->speed_hz set Date: Thu, 2 May 2013 12:34:55 +0200 Message-ID: <5182414F.1000201@atmel.com> References: <1362626715-6549-1-git-send-email-wenyou.yang@atmel.com> <1362626815-6628-1-git-send-email-wenyou.yang@atmel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Richard Genoud , Joachim Eastwood , Mark Brown , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Yang, Wenyou" , "spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , "plagnioj-sclMFOaUSTBWk0Htik3J/w@public.gmane.org" , "Lin, JM" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" To: "grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org" , Grant Likely Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org T24gMDIvMDUvMjAxMyAxMDoxMiwgUmljaGFyZCBHZW5vdWQgOgo+IDIwMTMvNS8yIFlhbmcsIFdl bnlvdSA8V2VueW91LllhbmdAYXRtZWwuY29tPjoKPj4gSGksIEpvYWNoaW0sCj4+Cj4+PiAtLS0t LU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+Pj4gRnJvbTogSm9hY2hpbSBFYXN0d29vZCBbbWFpbHRv Om1hbmFiaWFuQGdtYWlsLmNvbV0KPj4+IFNlbnQ6IDIwMTPlubQz5pyIN+aXpSAyMDozMQo+Pj4g VG86IFlhbmcsIFdlbnlvdQo+Pj4gQ2M6IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFk Lm9yZzsgZ3JhbnQubGlrZWx5QHNlY3JldGxhYi5jYTsgRmVycmUsCj4+PiBOaWNvbGFzOyBwbGFn bmlvakBqY3Jvc29mdC5jb207IHJpY2hhcmQuZ2Vub3VkQGdtYWlsLmNvbTsgTGluLCBKTTsKPj4+ IHNwaS1kZXZlbC1nZW5lcmFsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldDsgbGludXgta2VybmVsQHZn ZXIua2VybmVsLm9yZwo+Pj4gU3ViamVjdDogUmU6IFtQQVRDSCB2NiAwMS8xNl0gc3BpL3NwaS1h dG1lbDogZml4IHByb2JpbmcgZmFpbHVyZSBhZnRlcgo+Pj4geGZlci0+c3BlZWRfaHogc2V0Cj4+ Pgo+Pj4gT24gNyBNYXJjaCAyMDEzIDA0OjI2LCBXZW55b3UgWWFuZyA8d2VueW91LnlhbmdAYXRt ZWwuY29tPiB3cm90ZToKPj4+PiBjb21taXQ6IDA1OWI4ZmZlZWU1YjQyNzk0OTg3MmJiNmVkNWRi NWFlMDc4ODA1NGUKPj4+PiBjYXVzZSB0aGUgYXRtZWwgc3BpIHByb2JpbmcgZmFpbHVyZS4KPj4+ Pgo+Pj4+IFNpZ25lZC1vZmYtYnk6IFdlbnlvdSBZYW5nIDx3ZW55b3UueWFuZ0BhdG1lbC5jb20+ Cj4+Pj4gQ2M6IHNwaS1kZXZlbC1nZW5lcmFsQGxpc3RzLnNvdXJjZWZvcmdlLm5ldAo+Pj4+IENj OiBsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnCj4+Pj4gLS0tCj4+Pj4gICBkcml2ZXJzL3Nw aS9zcGktYXRtZWwuYyB8ICAgIDYgKysrLS0tCj4+Pj4gICAxIGZpbGUgY2hhbmdlZCwgMyBpbnNl cnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+Pj4+Cj4+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMv c3BpL3NwaS1hdG1lbC5jIGIvZHJpdmVycy9zcGkvc3BpLWF0bWVsLmMKPj4+PiBpbmRleCA2NTZk MTM3Li4xZWNhODE1IDEwMDY0NAo+Pj4+IC0tLSBhL2RyaXZlcnMvc3BpL3NwaS1hdG1lbC5jCj4+ Pj4gKysrIGIvZHJpdmVycy9zcGkvc3BpLWF0bWVsLmMKPj4+PiBAQCAtODQ2LDkgKzg0Niw5IEBA IHN0YXRpYyBpbnQgYXRtZWxfc3BpX3RyYW5zZmVyKHN0cnVjdCBzcGlfZGV2aWNlICpzcGksCj4+ PiBzdHJ1Y3Qgc3BpX21lc3NhZ2UgKm1zZykKPj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAg fQo+Pj4+ICAgICAgICAgICAgICAgICAgfQo+Pj4+Cj4+Pj4gLSAgICAgICAgICAgICAgIC8qIEZJ WE1FIGltcGxlbWVudCB0aGVzZSBwcm90b2NvbCBvcHRpb25zISEgKi8KPj4+PiAtICAgICAgICAg ICAgICAgaWYgKHhmZXItPnNwZWVkX2h6KSB7Cj4+Pj4gLSAgICAgICAgICAgICAgICAgICAgICAg ZGV2X2RiZygmc3BpLT5kZXYsICJubyBwcm90b2NvbCBvcHRpb25zCj4+PiB5ZXRcbiIpOwo+Pj4+ ICsgICAgICAgICAgICAgICBpZiAoeGZlci0+c3BlZWRfaHogPCBzcGktPm1heF9zcGVlZF9oeikg ewo+Pj4+ICsgICAgICAgICAgICAgICAgICAgICAgIGRldl9kYmcoJnNwaS0+ZGV2LAo+Pj4+ICsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgInNwZWVkIGluIHRyYW5zZmVyIGxlc3MgdGhh biBidXMKPj4+IHNwZWVkXG4iKTsKPj4+PiAgICAgICAgICAgICAgICAgICAgICAgICAgcmV0dXJu IC1FTk9QUk9UT09QVDsKPj4+PiAgICAgICAgICAgICAgICAgIH0KPj4+Cj4+PiBJIHNlbnQgYSBz aW1pbGFyIHBhdGNoIHRvIHNwaS1kZXZsIGEgd2hpbGUgYWdvLCB3aGljaCBHcmFudCBzYWlkIGhl IGFwcGxpZWQuCj4+PiBodHRwczovL3BhdGNod29yay5rZXJuZWwub3JnL3BhdGNoLzIxNjUzMDEv Cj4+Pgo+Pj4gQ2FuJ3QgZmluZCB0aGUgcGF0Y2ggaW4gYW55IHVwc3RyZWFtIGdpdCB0cmVlIHNv IEkgZ3Vlc3MgR3JhbnQgaGFzbid0Cj4+PiBwdXNoZWQgaXQgeWV0Lgo+PiBUaGlzIHBhdGNoIGhh c24ndCBzdGlsbCBhcHBsaWVkIGluIGFueSB1cHN0cmVhbSBnaXQgdHJlZSwgc28gQXRtZWwgc3Bp IG1hc3RlciBkb2Vzbid0IHdvcmsuCj4+IENvdWxkIHlvdSBoZWxwIGRvIHNvbWUgcGluZyBpdD8K Pgo+IGl0J3MgaW4gbGludXgtbmV4dDoKPiAzZDM1MjI2MDRhNTU1N2U4MGZkY2FiNjFjNTRiZDA0 ZWFmMTViNTI1Cj4gbWVyZ2VkIGZyb20gc3BpLWN1cnJlbnQvc3BpL21lcmdlCgpUaGFua3MgUmlj aGFyZCwgeWVzIEkgY2FuIGZpbmQgaXQgaGVyZToKaHR0cDovL2dpdC5zZWNyZXRsYWIuY2EvP3A9 bGludXguZ2l0O2E9Y29tbWl0O2g9M2QzNTIyNjA0YTU1NTdlODBmZGNhYjYxYzU0YmQwNGVhZjE1 YjUyNQoKR3JhbnQsIE1hcmssCgpDYW4geW91IHRlbGwgdXMgaWYgdGhpcyBTUEkgcGF0Y2ggd2ls bCBiZSBtZXJnZWQgdXBzdHJlYW0gdXNpbmcgb25lIG9mIAp5b3VyIHBhdGhzPwoKQmVzdCByZWdh cmRzLAotLSAKTmljb2xhcyBGZXJyZQoKLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCkludHJvZHVjaW5n IEFwcER5bmFtaWNzIExpdGUsIGEgZnJlZSB0cm91Ymxlc2hvb3RpbmcgdG9vbCBmb3IgSmF2YS8u TkVUCkdldCAxMDAlIHZpc2liaWxpdHkgaW50byB5b3VyIHByb2R1Y3Rpb24gYXBwbGljYXRpb24g LSBhdCBubyBjb3N0LgpDb2RlLWxldmVsIGRpYWdub3N0aWNzIGZvciBwZXJmb3JtYW5jZSBib3R0 bGVuZWNrcyB3aXRoIDwyJSBvdmVyaGVhZApEb3dubG9hZCBmb3IgZnJlZSBhbmQgZ2V0IHN0YXJ0 ZWQgdHJvdWJsZXNob290aW5nIGluIG1pbnV0ZXMuCmh0dHA6Ly9wLnNmLm5ldC9zZnUvYXBwZHlu X2QyZF9hcDEKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K c3BpLWRldmVsLWdlbmVyYWwgbWFpbGluZyBsaXN0CnNwaS1kZXZlbC1nZW5lcmFsQGxpc3RzLnNv dXJjZWZvcmdlLm5ldApodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0aW5m by9zcGktZGV2ZWwtZ2VuZXJhbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Thu, 2 May 2013 12:34:55 +0200 Subject: [PATCH v6 01/16] spi/spi-atmel: fix probing failure after xfer->speed_hz set In-Reply-To: References: <1362626715-6549-1-git-send-email-wenyou.yang@atmel.com> <1362626815-6628-1-git-send-email-wenyou.yang@atmel.com> Message-ID: <5182414F.1000201@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02/05/2013 10:12, Richard Genoud : > 2013/5/2 Yang, Wenyou : >> Hi, Joachim, >> >>> -----Original Message----- >>> From: Joachim Eastwood [mailto:manabian at gmail.com] >>> Sent: 2013?3?7? 20:31 >>> To: Yang, Wenyou >>> Cc: linux-arm-kernel at lists.infradead.org; grant.likely at secretlab.ca; Ferre, >>> Nicolas; plagnioj at jcrosoft.com; richard.genoud at gmail.com; Lin, JM; >>> spi-devel-general at lists.sourceforge.net; linux-kernel at vger.kernel.org >>> Subject: Re: [PATCH v6 01/16] spi/spi-atmel: fix probing failure after >>> xfer->speed_hz set >>> >>> On 7 March 2013 04:26, Wenyou Yang wrote: >>>> commit: 059b8ffeee5b427949872bb6ed5db5ae0788054e >>>> cause the atmel spi probing failure. >>>> >>>> Signed-off-by: Wenyou Yang >>>> Cc: spi-devel-general at lists.sourceforge.net >>>> Cc: linux-kernel at vger.kernel.org >>>> --- >>>> drivers/spi/spi-atmel.c | 6 +++--- >>>> 1 file changed, 3 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c >>>> index 656d137..1eca815 100644 >>>> --- a/drivers/spi/spi-atmel.c >>>> +++ b/drivers/spi/spi-atmel.c >>>> @@ -846,9 +846,9 @@ static int atmel_spi_transfer(struct spi_device *spi, >>> struct spi_message *msg) >>>> } >>>> } >>>> >>>> - /* FIXME implement these protocol options!! */ >>>> - if (xfer->speed_hz) { >>>> - dev_dbg(&spi->dev, "no protocol options >>> yet\n"); >>>> + if (xfer->speed_hz < spi->max_speed_hz) { >>>> + dev_dbg(&spi->dev, >>>> + "speed in transfer less than bus >>> speed\n"); >>>> return -ENOPROTOOPT; >>>> } >>> >>> I sent a similar patch to spi-devl a while ago, which Grant said he applied. >>> https://patchwork.kernel.org/patch/2165301/ >>> >>> Can't find the patch in any upstream git tree so I guess Grant hasn't >>> pushed it yet. >> This patch hasn't still applied in any upstream git tree, so Atmel spi master doesn't work. >> Could you help do some ping it? > > it's in linux-next: > 3d3522604a5557e80fdcab61c54bd04eaf15b525 > merged from spi-current/spi/merge Thanks Richard, yes I can find it here: http://git.secretlab.ca/?p=linux.git;a=commit;h=3d3522604a5557e80fdcab61c54bd04eaf15b525 Grant, Mark, Can you tell us if this SPI patch will be merged upstream using one of your paths? Best regards, -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757242Ab3EBKe6 (ORCPT ); Thu, 2 May 2013 06:34:58 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:54507 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754086Ab3EBKe5 (ORCPT ); Thu, 2 May 2013 06:34:57 -0400 Message-ID: <5182414F.1000201@atmel.com> Date: Thu, 2 May 2013 12:34:55 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130404 Thunderbird/17.0.5 MIME-Version: 1.0 To: "grant.likely@secretlab.ca" , Grant Likely CC: Richard Genoud , "Yang, Wenyou" , Joachim Eastwood , "linux-arm-kernel@lists.infradead.org" , "plagnioj@jcrosoft.com" , "Lin, JM" , "spi-devel-general@lists.sourceforge.net" , "linux-kernel@vger.kernel.org" , Mark Brown Subject: Re: [PATCH v6 01/16] spi/spi-atmel: fix probing failure after xfer->speed_hz set References: <1362626715-6549-1-git-send-email-wenyou.yang@atmel.com> <1362626815-6628-1-git-send-email-wenyou.yang@atmel.com> In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/05/2013 10:12, Richard Genoud : > 2013/5/2 Yang, Wenyou : >> Hi, Joachim, >> >>> -----Original Message----- >>> From: Joachim Eastwood [mailto:manabian@gmail.com] >>> Sent: 2013年3月7日 20:31 >>> To: Yang, Wenyou >>> Cc: linux-arm-kernel@lists.infradead.org; grant.likely@secretlab.ca; Ferre, >>> Nicolas; plagnioj@jcrosoft.com; richard.genoud@gmail.com; Lin, JM; >>> spi-devel-general@lists.sourceforge.net; linux-kernel@vger.kernel.org >>> Subject: Re: [PATCH v6 01/16] spi/spi-atmel: fix probing failure after >>> xfer->speed_hz set >>> >>> On 7 March 2013 04:26, Wenyou Yang wrote: >>>> commit: 059b8ffeee5b427949872bb6ed5db5ae0788054e >>>> cause the atmel spi probing failure. >>>> >>>> Signed-off-by: Wenyou Yang >>>> Cc: spi-devel-general@lists.sourceforge.net >>>> Cc: linux-kernel@vger.kernel.org >>>> --- >>>> drivers/spi/spi-atmel.c | 6 +++--- >>>> 1 file changed, 3 insertions(+), 3 deletions(-) >>>> >>>> diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c >>>> index 656d137..1eca815 100644 >>>> --- a/drivers/spi/spi-atmel.c >>>> +++ b/drivers/spi/spi-atmel.c >>>> @@ -846,9 +846,9 @@ static int atmel_spi_transfer(struct spi_device *spi, >>> struct spi_message *msg) >>>> } >>>> } >>>> >>>> - /* FIXME implement these protocol options!! */ >>>> - if (xfer->speed_hz) { >>>> - dev_dbg(&spi->dev, "no protocol options >>> yet\n"); >>>> + if (xfer->speed_hz < spi->max_speed_hz) { >>>> + dev_dbg(&spi->dev, >>>> + "speed in transfer less than bus >>> speed\n"); >>>> return -ENOPROTOOPT; >>>> } >>> >>> I sent a similar patch to spi-devl a while ago, which Grant said he applied. >>> https://patchwork.kernel.org/patch/2165301/ >>> >>> Can't find the patch in any upstream git tree so I guess Grant hasn't >>> pushed it yet. >> This patch hasn't still applied in any upstream git tree, so Atmel spi master doesn't work. >> Could you help do some ping it? > > it's in linux-next: > 3d3522604a5557e80fdcab61c54bd04eaf15b525 > merged from spi-current/spi/merge Thanks Richard, yes I can find it here: http://git.secretlab.ca/?p=linux.git;a=commit;h=3d3522604a5557e80fdcab61c54bd04eaf15b525 Grant, Mark, Can you tell us if this SPI patch will be merged upstream using one of your paths? Best regards, -- Nicolas Ferre