From: Mark Hatle <mark.hatle@windriver.com>
To: <openembedded-core@lists.openembedded.org>
Subject: Re: [PATCH] fs-perms.txt: Don't tinker with file modes in /usr/src/debug
Date: Thu, 2 May 2013 09:07:16 -0500 [thread overview]
Message-ID: <51827314.8080007@windriver.com> (raw)
In-Reply-To: <1367502902.14512.256.camel@phil-desktop.brightsign>
On 5/2/13 8:55 AM, Phil Blundell wrote:
> Since 6775feb9fe935ab01fd9cae2b2d3fce5824a9a72 our local "copy" of the
> debug sources has in fact been hardlinked to ${S} and potentially other
> places too. This means that any modifications we make to these files
> might have wider consequences than intended.
>
> Avoid this potential pitfall by telling fixup_perms() to leave the file
> modes in this directory alone. No great harm will result from shipping
> debug sources with a mode other than 0644: if the mode was permissive
> enough for us to compile the sources in the first place then it must
> also be permissive enough for subsequent debugging.
I'm fine with this as long as the uid/gid is set to root. (it is below)
Acked-by: Mark Hatle <mark.hatle@windriver.com>
> Signed-off-by: Phil Blundell <philb@gnu.org>
> ---
> meta/files/fs-perms.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta/files/fs-perms.txt b/meta/files/fs-perms.txt
> index ef44e26..becb85c 100644
> --- a/meta/files/fs-perms.txt
> +++ b/meta/files/fs-perms.txt
> @@ -41,7 +41,7 @@ ${includedir} 0755 root root true 0644 root root
> ${oldincludedir} 0755 root root true 0644 root root
>
> # Cleanup debug src
> -/usr/src/debug 0755 root root true 0644 root root
> +/usr/src/debug 0755 root root true - root root
>
> # Items from base-files
> # Links
>
prev parent reply other threads:[~2013-05-02 14:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-02 13:55 [PATCH] fs-perms.txt: Don't tinker with file modes in /usr/src/debug Phil Blundell
2013-05-02 14:07 ` Mark Hatle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51827314.8080007@windriver.com \
--to=mark.hatle@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.