From mboxrd@z Thu Jan 1 00:00:00 1970 From: eduardo.valentin@ti.com (Eduardo Valentin) Date: Thu, 2 May 2013 11:46:13 -0400 Subject: [PATCH, RFC 12/22] thermal: cpu_cooling: fix stub function In-Reply-To: <1367507786-505303-13-git-send-email-arnd@arndb.de> References: <1367507786-505303-1-git-send-email-arnd@arndb.de> <1367507786-505303-13-git-send-email-arnd@arndb.de> Message-ID: <51828A45.60909@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 02-05-2013 11:16, Arnd Bergmann wrote: > The function stub for cpufreq_cooling_get_level introduced > in 57df81069 "Thermal: exynos: fix cooling state translation" > is not syntactically correct C and needs to be fixed to avoid > this error: > > In file included from drivers/thermal/db8500_thermal.c:20:0: > include/linux/cpu_cooling.h: In function 'cpufreq_cooling_get_level': > include/linux/cpu_cooling.h:57:1: > error: parameter name omitted unsigned long cpufreq_cooling_get_level(unsigned int, unsigned int) ^ > include/linux/cpu_cooling.h:57:1: error: parameter name omitted > > Cc: Eduardo Valentin > Cc: Zhang Rui > Cc: Amit Daniel kachhap > Signed-off-by: Arnd Bergmann > --- > include/linux/cpu_cooling.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/linux/cpu_cooling.h b/include/linux/cpu_cooling.h > index 282e270..cf03111 100644 > --- a/include/linux/cpu_cooling.h > +++ b/include/linux/cpu_cooling.h > @@ -54,7 +54,7 @@ void cpufreq_cooling_unregister(struct thermal_cooling_device *cdev) > return; > } > static inline > -unsigned long cpufreq_cooling_get_level(unsigned int, unsigned int) > +unsigned long cpufreq_cooling_get_level(unsigned int cpu, unsigned int freq) While there, could you please also include the following (same, but on the function declaration on line 44), just to keep the header in same style? diff --git a/include/linux/cpu_cooling.h b/include/linux/cpu_cooling.h index 282e270..c023afa 100644 --- a/include/linux/cpu_cooling.h +++ b/include/linux/cpu_cooling.h @@ -41,7 +41,7 @@ cpufreq_cooling_register(const struct cpumask *clip_cpus); */ void cpufreq_cooling_unregister(struct thermal_cooling_device *cdev); -unsigned long cpufreq_cooling_get_level(unsigned int, unsigned int); +unsigned long cpufreq_cooling_get_level(unsigned int cpu, unsigned int freq); #else /* !CONFIG_CPU_THERMAL */ static inline struct thermal_cooling_device * cpufreq_cooling_register(const struct cpumask *clip_cpus) > { > return THERMAL_CSTATE_INVALID; > } > -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 295 bytes Desc: OpenPGP digital signature URL: From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760121Ab3EBPq7 (ORCPT ); Thu, 2 May 2013 11:46:59 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:40844 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758614Ab3EBPq6 (ORCPT ); Thu, 2 May 2013 11:46:58 -0400 Message-ID: <51828A45.60909@ti.com> Date: Thu, 2 May 2013 11:46:13 -0400 From: Eduardo Valentin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Arnd Bergmann CC: , , Eduardo Valentin , Zhang Rui , Amit Daniel kachhap Subject: Re: [PATCH, RFC 12/22] thermal: cpu_cooling: fix stub function References: <1367507786-505303-1-git-send-email-arnd@arndb.de> <1367507786-505303-13-git-send-email-arnd@arndb.de> In-Reply-To: <1367507786-505303-13-git-send-email-arnd@arndb.de> X-Enigmail-Version: 1.5.1 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="----enig2XOWLPHIHPCKXLQEMASVU" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ------enig2XOWLPHIHPCKXLQEMASVU Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 02-05-2013 11:16, Arnd Bergmann wrote: > The function stub for cpufreq_cooling_get_level introduced > in 57df81069 "Thermal: exynos: fix cooling state translation" > is not syntactically correct C and needs to be fixed to avoid > this error: >=20 > In file included from drivers/thermal/db8500_thermal.c:20:0: > include/linux/cpu_cooling.h: In function 'cpufreq_cooling_get_level': > include/linux/cpu_cooling.h:57:1: > error: parameter name omitted unsigned long cpufreq_cooling_get_level= (unsigned int, unsigned int) ^ > include/linux/cpu_cooling.h:57:1: error: parameter name omitted >=20 > Cc: Eduardo Valentin > Cc: Zhang Rui > Cc: Amit Daniel kachhap > Signed-off-by: Arnd Bergmann > --- > include/linux/cpu_cooling.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/include/linux/cpu_cooling.h b/include/linux/cpu_cooling.h > index 282e270..cf03111 100644 > --- a/include/linux/cpu_cooling.h > +++ b/include/linux/cpu_cooling.h > @@ -54,7 +54,7 @@ void cpufreq_cooling_unregister(struct thermal_coolin= g_device *cdev) > return; > } > static inline > -unsigned long cpufreq_cooling_get_level(unsigned int, unsigned int) > +unsigned long cpufreq_cooling_get_level(unsigned int cpu, unsigned int= freq) While there, could you please also include the following (same, but on the function declaration on line 44), just to keep the header in same sty= le? diff --git a/include/linux/cpu_cooling.h b/include/linux/cpu_cooling.h index 282e270..c023afa 100644 --- a/include/linux/cpu_cooling.h +++ b/include/linux/cpu_cooling.h @@ -41,7 +41,7 @@ cpufreq_cooling_register(const struct cpumask *clip_cpu= s); */ void cpufreq_cooling_unregister(struct thermal_cooling_device *cdev); -unsigned long cpufreq_cooling_get_level(unsigned int, unsigned int); +unsigned long cpufreq_cooling_get_level(unsigned int cpu, unsigned int freq); #else /* !CONFIG_CPU_THERMAL */ static inline struct thermal_cooling_device * cpufreq_cooling_register(const struct cpumask *clip_cpus) > { > return THERMAL_CSTATE_INVALID; > } >=20 ------enig2XOWLPHIHPCKXLQEMASVU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iF4EAREIAAYFAlGCikUACgkQCXcVR3XQvP0FpwD+KQTtlyfLHBI7aXXXuGmkOzBM KecrjlcmQ+xCXmFF4GsBAIeNbcDS3YpnpJre3BQS0Troqt/j8rAczQdOehxTMMMU =+Zkq -----END PGP SIGNATURE----- ------enig2XOWLPHIHPCKXLQEMASVU--