Re: [PATCH 8/9] s3c2410fb: Remove redundant platform_set_drvdata()

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 8/9] s3c2410fb: Remove redundant platform_set_drvdata()
Date: Thu, 02 May 2013 20:11:07 +0000	[thread overview]
Message-ID: <5182C85B.7090305@gmail.com> (raw)
In-Reply-To: <000001ce46f6$54f27cc0$fed77640$@samsung.com>

Hi Jingoo,

On 05/02/2013 07:31 AM, Jingoo Han wrote:
> On Saturday, April 27, 2013 5:02 AM, Sylwester Nawrocki wrote:
>> >  driver_data field is being cleared by the driver core since
>> >  commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
>> >  device-core: Ensure drvdata = NULL when no driver is bound
>> >  hence there is no need to do it in the driver's remove() callback.

> How about eliminating platform_set_drvdata(pdev, NULL)
> in s3c24xxfb_probe() as well as s3c2410fb_remove()?

Ah, thanks for pointing out. Indeed, that could be dropped too, I've
overlooked it somehow. Will update and resend this patch shortly.

Regards,
Sylwester

WARNING: multiple messages have this Message-ID (diff)

From: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
To: Jingoo Han <jg1.han@samsung.com>
Cc: kgene.kim@samsung.com, FlorianSchandinat@gmx.de,
	linux-arm-kernel@lists.infradead.org,
	linux-fbdev@vger.kernel.org, linux-samsung-soc@vger.kernel.org
Subject: Re: [PATCH 8/9] s3c2410fb: Remove redundant platform_set_drvdata()
Date: Thu, 02 May 2013 22:11:07 +0200	[thread overview]
Message-ID: <5182C85B.7090305@gmail.com> (raw)
In-Reply-To: <000001ce46f6$54f27cc0$fed77640$@samsung.com>

Hi Jingoo,

On 05/02/2013 07:31 AM, Jingoo Han wrote:
> On Saturday, April 27, 2013 5:02 AM, Sylwester Nawrocki wrote:
>> >  driver_data field is being cleared by the driver core since
>> >  commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
>> >  device-core: Ensure drvdata = NULL when no driver is bound
>> >  hence there is no need to do it in the driver's remove() callback.

> How about eliminating platform_set_drvdata(pdev, NULL)
> in s3c24xxfb_probe() as well as s3c2410fb_remove()?

Ah, thanks for pointing out. Indeed, that could be dropped too, I've
overlooked it somehow. Will update and resend this patch shortly.

Regards,
Sylwester

WARNING: multiple messages have this Message-ID (diff)

From: sylvester.nawrocki@gmail.com (Sylwester Nawrocki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 8/9] s3c2410fb: Remove redundant platform_set_drvdata()
Date: Thu, 02 May 2013 22:11:07 +0200	[thread overview]
Message-ID: <5182C85B.7090305@gmail.com> (raw)
In-Reply-To: <000001ce46f6$54f27cc0$fed77640$@samsung.com>

Hi Jingoo,

On 05/02/2013 07:31 AM, Jingoo Han wrote:
> On Saturday, April 27, 2013 5:02 AM, Sylwester Nawrocki wrote:
>> >  driver_data field is being cleared by the driver core since
>> >  commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
>> >  device-core: Ensure drvdata = NULL when no driver is bound
>> >  hence there is no need to do it in the driver's remove() callback.

> How about eliminating platform_set_drvdata(pdev, NULL)
> in s3c24xxfb_probe() as well as s3c2410fb_remove()?

Ah, thanks for pointing out. Indeed, that could be dropped too, I've
overlooked it somehow. Will update and resend this patch shortly.

Regards,
Sylwester

next prev parent reply	other threads:[~2013-05-02 20:11 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26 20:02 [PATCH 0/9] s3c24xx LCD controller driver cleanup Sylwester Nawrocki
2013-04-26 20:02 ` Sylwester Nawrocki
2013-04-26 20:02 ` Sylwester Nawrocki
2013-04-26 20:02 ` [PATCH 1/9] s3c2410fb: Move platform data declarations to include/linux/platform_data Sylwester Nawrocki
2013-04-26 20:02   ` Sylwester Nawrocki
2013-04-26 20:02   ` Sylwester Nawrocki
2013-04-26 20:02 ` [PATCH 2/9] s3c2410fb: Make most of register definitions local Sylwester Nawrocki
2013-04-26 20:02   ` Sylwester Nawrocki
2013-04-26 20:02   ` Sylwester Nawrocki
2013-04-26 20:02 ` [PATCH 3/9] ARM: S3C24XX: Remove include/mach/regs-lcd.h header file Sylwester Nawrocki
2013-04-26 20:02   ` Sylwester Nawrocki
2013-04-26 20:02   ` Sylwester Nawrocki
2013-04-26 20:02 ` [PATCH 4/9] s3c2410fb: Register single platform driver Sylwester Nawrocki
2013-04-26 20:02   ` Sylwester Nawrocki
2013-04-26 20:02   ` Sylwester Nawrocki
2013-04-26 20:02 ` [PATCH 5/9] s3c2410fb: Use dev_pm_ops Sylwester Nawrocki
2013-04-26 20:02   ` Sylwester Nawrocki
2013-04-26 20:02   ` Sylwester Nawrocki
2013-04-26 20:02 ` [PATCH 6/9] s3c2410fb: Enable display by default Sylwester Nawrocki
2013-04-26 20:02   ` Sylwester Nawrocki
2013-04-26 20:02   ` Sylwester Nawrocki
2013-04-26 20:02 ` [PATCH 7/9] s3c2410fb: Use devm_ioremap_resource() Sylwester Nawrocki
2013-04-26 20:02   ` Sylwester Nawrocki
2013-04-26 20:02   ` Sylwester Nawrocki
2013-04-26 20:02 ` [PATCH 8/9] s3c2410fb: Remove redundant platform_set_drvdata() Sylwester Nawrocki
2013-04-26 20:02   ` Sylwester Nawrocki
2013-04-26 20:02   ` Sylwester Nawrocki
2013-05-02  5:31   ` Jingoo Han
2013-05-02  5:31     ` Jingoo Han
2013-05-02  5:31     ` Jingoo Han
2013-05-02 20:11     ` Sylwester Nawrocki [this message]
2013-05-02 20:11       ` Sylwester Nawrocki
2013-05-02 20:11       ` Sylwester Nawrocki
2013-04-26 20:02 ` [PATCH 9/9] s3c2410fb: Use module parameter instead of a sysfs entry Sylwester Nawrocki
2013-04-26 20:02   ` Sylwester Nawrocki
2013-04-26 20:02   ` Sylwester Nawrocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5182C85B.7090305@gmail.com \
    --to=sylvester.nawrocki@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.