From: Steve Grubb <sgrubb@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: linux-audit@redhat.com
Subject: Re: [PATCH] errormsg: use descriptive macros for error numbers
Date: Tue, 11 Apr 2017 17:33:08 -0400 [thread overview]
Message-ID: <5183071.ISI9gAqKeZ@x2> (raw)
In-Reply-To: <1491302212-521-1-git-send-email-rgb@redhat.com>
On Tuesday, April 4, 2017 6:36:52 AM EDT Richard Guy Briggs wrote:
> Convert all the numerical error return codes in comparison option and field
> option parsing routines audit_rule_interfield_comp_data() and
> audit_rule_fieldpair_data() to descriptive macros for easier code navigation
> and verification.
>
> See: https://github.com/linux-audit/audit-userspace/issues/11
>
> Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
> ---
> lib/errormsg.h | 29 +++++++++++++++++++
> lib/libaudit.c | 84
> ++++++++++++++++++++++++++++---------------------------- 2 files changed,
> 71 insertions(+), 42 deletions(-)
Applied. But we still have hardcoded numbers in the err_msgtab[]. :-)
Thanks,
-Steve
next prev parent reply other threads:[~2017-04-11 21:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-04 10:36 [PATCH] errormsg: use descriptive macros for error numbers Richard Guy Briggs
2017-04-11 21:33 ` Steve Grubb [this message]
2017-04-12 6:39 ` Richard Guy Briggs
2017-04-12 22:14 ` Steve Grubb
2017-04-13 8:42 ` Richard Guy Briggs
2017-05-17 1:32 ` Richard Guy Briggs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5183071.ISI9gAqKeZ@x2 \
--to=sgrubb@redhat.com \
--cc=linux-audit@redhat.com \
--cc=rgb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.