All of lore.kernel.org
 help / color / mirror / Atom feed
From: Huang Shijie <b32955@freescale.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org,
	linux-kernel@vger.kernel.org, "Gupta, Pekon" <pekon@ti.com>,
	dedekind1@gmail.com
Subject: Re: [PATCH V4 4/9] mtd: get the ECC info from the Extended Parameter Page
Date: Fri, 3 May 2013 10:52:53 +0800	[thread overview]
Message-ID: <51832685.8030503@freescale.com> (raw)
In-Reply-To: <CAN8TOE8NnbDTvLPyi5=dciLmLBP2EfSpvYN1GLscy+L0roP6jw@mail.gmail.com>

于 2013年05月03日 07:39, Brian Norris 写道:
> only run the extended parameter page function after that point.
sorry, I prefer to run the extended parameter page function here just 
following the case
"p-> ecc_bits != 0xff". IMHO, the two cases should be put together as 
the onfi spec tells, rather be split out
far away. The extended parameter page function is just the case 
"p->ecc_bits == 0xff".

If we put the nand_flash_detect_ext_param_page() after the point we 
reassign the chip->cmdfunc,
It's a little discrete in logic which makes the code not compact enough.

btw: Could you check you email client? I failed several times for the 
HTML issue.

thanks
Huang Shijie

WARNING: multiple messages have this Message-ID (diff)
From: Huang Shijie <b32955@freescale.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: <dwmw2@infradead.org>, <dedekind1@gmail.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>,
	"Gupta, Pekon" <pekon@ti.com>
Subject: Re: [PATCH V4 4/9] mtd: get the ECC info from the Extended Parameter Page
Date: Fri, 3 May 2013 10:52:53 +0800	[thread overview]
Message-ID: <51832685.8030503@freescale.com> (raw)
In-Reply-To: <CAN8TOE8NnbDTvLPyi5=dciLmLBP2EfSpvYN1GLscy+L0roP6jw@mail.gmail.com>

于 2013年05月03日 07:39, Brian Norris 写道:
> only run the extended parameter page function after that point.
sorry, I prefer to run the extended parameter page function here just 
following the case
"p-> ecc_bits != 0xff". IMHO, the two cases should be put together as 
the onfi spec tells, rather be split out
far away. The extended parameter page function is just the case 
"p->ecc_bits == 0xff".

If we put the nand_flash_detect_ext_param_page() after the point we 
reassign the chip->cmdfunc,
It's a little discrete in logic which makes the code not compact enough.

btw: Could you check you email client? I failed several times for the 
HTML issue.

thanks
Huang Shijie



  reply	other threads:[~2013-05-03  2:51 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-26  9:08 [PATCH V4 0/9] mtd: add datasheet's ECC information to nand_chip{} Huang Shijie
2013-04-26  9:08 ` Huang Shijie
2013-04-26  9:08 ` [PATCH V4 1/9] mtd: add more comment for ecc_strength/ecc_size Huang Shijie
2013-04-26  9:08   ` Huang Shijie
2013-05-15  7:27   ` Artem Bityutskiy
2013-05-15  7:27     ` Artem Bityutskiy
2013-05-15  7:38     ` Huang Shijie
2013-05-15  7:38       ` Huang Shijie
2013-05-15  7:42       ` Artem Bityutskiy
2013-05-15  7:42         ` Artem Bityutskiy
2013-05-15  8:02         ` Huang Shijie
2013-05-15  8:02           ` Huang Shijie
2013-05-15 10:01           ` Artem Bityutskiy
2013-05-15 10:01             ` Artem Bityutskiy
2013-04-26  9:08 ` [PATCH V4 2/9] mtd: add data structures for Extended Parameter Page Huang Shijie
2013-04-26  9:08   ` Huang Shijie
2013-05-02  7:42   ` Gupta, Pekon
2013-04-26  9:08 ` [PATCH V4 3/9] mtd: add a helper to get the supported features for ONFI nand Huang Shijie
2013-04-26  9:08   ` Huang Shijie
2013-04-26  9:08 ` [PATCH V4 4/9] mtd: get the ECC info from the Extended Parameter Page Huang Shijie
2013-04-26  9:08   ` Huang Shijie
2013-05-02  7:43   ` Gupta, Pekon
2013-05-02 23:39   ` Brian Norris
2013-05-02 23:39     ` Brian Norris
2013-05-03  2:52     ` Huang Shijie [this message]
2013-05-03  2:52       ` Huang Shijie
2013-04-26  9:08 ` [PATCH V4 5/9] mtd: replace the hardcode with the onfi_feature() Huang Shijie
2013-04-26  9:08   ` Huang Shijie
2013-04-30 10:04   ` Gupta, Pekon
2013-04-30 10:04     ` Gupta, Pekon
2013-05-02  2:14     ` Huang Shijie
2013-05-02  2:14       ` Huang Shijie
2013-05-02  5:42       ` Gupta, Pekon
2013-05-02  5:42         ` Gupta, Pekon
2013-05-02  6:01         ` Huang Shijie
2013-05-02  6:01           ` Huang Shijie
2013-05-02  6:17           ` Gupta, Pekon
2013-05-02  6:17             ` Gupta, Pekon
2013-05-02  6:48             ` Huang Shijie
2013-05-02  6:48               ` Huang Shijie
2013-05-02 21:24               ` Brian Norris
2013-05-02 21:24                 ` Brian Norris
2013-04-26  9:08 ` [PATCH V4 6/9] mtd: add ECC info for nand_flash_dev{} Huang Shijie
2013-04-26  9:08   ` Huang Shijie
2013-04-26  9:08 ` [PATCH V4 7/9] mtd: parse out the ECC info for the full-id nand chips Huang Shijie
2013-04-26  9:08   ` Huang Shijie
2013-04-26  9:08 ` [PATCH V4 8/9] mtd: add the ecc info for some " Huang Shijie
2013-04-26  9:08   ` Huang Shijie
2013-04-26  9:08 ` [PATCH V4 9/9] mtd: gpmi: set the BCH's geometry with the ecc info Huang Shijie
2013-04-26  9:08   ` Huang Shijie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51832685.8030503@freescale.com \
    --to=b32955@freescale.com \
    --cc=computersforpeace@gmail.com \
    --cc=dedekind1@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=pekon@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.